From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f41.google.com (mail-ej1-f41.google.com [209.85.218.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD9D63232 for ; Mon, 13 Jan 2025 14:31:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736778681; cv=none; b=gCyu9uJXk3pvEI5y91kNwTKKbGDkvkO+O6V2ALDnsMiz3SHsow2JhDcDx5WLRc24TgbM3NFGJm4GYXCthkhi5Wmx9fWgz0p0oKXNjVbI6jB/l1l0g1nBWosqxG7AMUzJGJO9zlmO2mB/FH4wlKdHMCShhCMQcmiUfyPoX+IXrAA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736778681; c=relaxed/simple; bh=NSNTWcXj99pSXBBljdPWocplE2UAeV6Mxb6hqTZ314U=; h=Message-ID:Date:MIME-Version:Subject:From:To:References: In-Reply-To:Content-Type; b=WVpCPkPG0h8xtLipsAOR1W1Jhqif2gkWMrO/dsVGHxE8kV4dEaJPRunTp1/vWOQovA8I1M+foQ40phw1ijtbt3pyxmiwdFb2DPxEour31B/1FAkpKAwkIxAubCiAZ4+WtEgY+s4e+bNoZQJUYVj2Sjfx5Jisu1Nij0HCNJZN8FU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=y3g/h4mx; arc=none smtp.client-ip=209.85.218.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="y3g/h4mx" Received: by mail-ej1-f41.google.com with SMTP id a640c23a62f3a-aa67773ffd4so69120566b.2 for ; Mon, 13 Jan 2025 06:31:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736778678; x=1737383478; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=weZd1YPhQuUCvQ4RDNP5bOvLU3u0h0XqN020or2wmR4=; b=y3g/h4mx2/S/wuXDT9It1xp9xL30O8GS/eWBVfu5Oc0Y72CnbVyXZ22SPnc/QETeuU GHV92VM73bgUfmk7hFAIILx7fFP191TWKUq3Xrl4N9KsV20jgGDGWMppCMuIctjrfB3v x9ZUDx9DLId1ILXaeljtuxO0Ywe/VApZ9OKWRjzDHz9Xm5npzc/QI+GoAV0O2LJWO7wj +0tuXi3SjZ6xL/GcLgc7wUcz4I0MXE2PPlCsmq7+mSu7fogRiMxZLMEkbckpsLyyyeBi u2QrdrTGLZNnj0ESapyHJ/odw9I8/Eq7vbH4y/Wv8xMGeFykyW67sPRqM6jZjUesm+Uc Kz4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736778678; x=1737383478; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :references:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=weZd1YPhQuUCvQ4RDNP5bOvLU3u0h0XqN020or2wmR4=; b=ufk0ULAqnFkJeJ9qYlcj0/L43FgOn3xq/s0xxG98CX8CHyGuQCaan1hzRUu3OwbIgY Iz8IkV/oaQ1wJO0dsmi6OziZFvEgmhCbtNvyu40CoMXzb4L06jJYj3aWUVOA643igX+n pZ3ZCVGiEn6iUTvlmxWyr8KxboZucbUGCVYB0TImMCbzYSdPuVEQ19C3ADkczLGQ2A9T pbRzlDgtN9LwwbElb9A1xHEoqEekJyqta37UcrQA3Ef/+Oa2DIwonhVK0ITJCc3dh2BF uugmXf4lnA35Jy1mo2Lsj+LqPCV4ntiPx5Xl8faPQA2/nCcS90i6kKulKUQbMJknSXeH lRnQ== X-Forwarded-Encrypted: i=1; AJvYcCW6DEcsMTM0ikf/V/vKheJ1CnMU7Xjd8De97dUbfkJtuZg5JfX+zlyVj1GYIlePZk8spKqX+4zBSh+sbA8=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9UtQc9JQEyQoNFV3RuBffCAZKPB5DbhFIxfh8ZIHY5k/JgVo6 t2it50fMZ+ph+W4b3R04ZElbJNlKqQ/xhcxoQVHGwY4NMrUt4L+NG18yyR4whS0= X-Gm-Gg: ASbGncsURTmLpwa0v2ZiUFpcU4BJEdzMy6o3UiUebCU99TY9IUdF6WiMUIeh0UOv0L5 Oykk++ysc/6GHwypST+vswhkAqHEq5HuUhdbDSW9ZI63qfvAqYhZXqsQV9oA4XiuD6G7iJvNw7n TtAyayQhla6GprHa6Vlopf71dBuIH9S055aXzkYLweGi3+ekPFORa2R37yHmebQinujjry2A9k5 fQTAnzCNPBkl9//cSIXdmSu4afD67yxHlJyV9RNbzdAuW5o7shVMxopJv+TAhE+LuySAlEzgSrv X-Google-Smtp-Source: AGHT+IEAnOrirhqKrZI35EhezJop8U5ASFryXKh28Rcj0FE/w9WQIIxkrVg+p1gB3+++8zgOwVFz+A== X-Received: by 2002:a17:907:9686:b0:aa6:193c:f391 with SMTP id a640c23a62f3a-ab2ab170994mr728819566b.2.1736778677847; Mon, 13 Jan 2025 06:31:17 -0800 (PST) Received: from [192.168.1.20] ([178.197.223.165]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab2c9134403sm516717666b.90.2025.01.13.06.31.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 06:31:17 -0800 (PST) Message-ID: <48e4def6-3d40-4cbe-8008-a299869342b0@linaro.org> Date: Mon, 13 Jan 2025 15:31:16 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] drm/mediatek/hdmi: Use syscon_regmap_lookup_by_phandle_args From: Krzysztof Kozlowski To: AngeloGioacchino Del Regno , Chun-Kuang Hu , Philipp Zabel , David Airlie , Simona Vetter , Matthias Brugger , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20250112134708.46100-1-krzysztof.kozlowski@linaro.org> <516d16e3-6fc6-49ba-a0ce-f451b65a6c1a@collabora.com> Content-Language: en-US Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 13/01/2025 15:27, Krzysztof Kozlowski wrote: > On 13/01/2025 14:58, AngeloGioacchino Del Regno wrote: >> Il 13/01/25 14:05, Krzysztof Kozlowski ha scritto: >>> On 13/01/2025 13:41, AngeloGioacchino Del Regno wrote: >>>> Il 12/01/25 14:47, Krzysztof Kozlowski ha scritto: >>>>> Use syscon_regmap_lookup_by_phandle_args() which is a wrapper over >>>>> syscon_regmap_lookup_by_phandle() combined with getting the syscon >>>>> argument. Except simpler code this annotates within one line that given >>>>> phandle has arguments, so grepping for code would be easier. >>>>> >>>>> There is also no real benefit in printing errors on missing syscon >>>>> argument, because this is done just too late: runtime check on >>>>> static/build-time data. Dtschema and Devicetree bindings offer the >>>>> static/build-time check for this already. >>>>> >>>> >>>> I agree with this change but can you please rebase it over [1]? >>>> >>>> The same code got migrated to mtk_hdmi_common.c instead :-) >>>> >>>> [1]: >>>> https://lore.kernel.org/r/20250108112744.64686-1-angelogioacchino.delregno@collabora.com >>> My is 2-patch cleanup, your is 34 patch rework and new features with >>> existing build reports, so rebase is not reasonable. It would make this >>> 2-patch cleanup wait for many cycles. >>> >> If adding the `#include ` line to a file would take >> *many cycles*, that'd be a bit weird, wouldn't it? :-) > It's not about include, it is about rebase. If I rebase on 34-patchset, > that's my dependency and this work cannot be merged before yours is. > > And yours already have kbuild reports, so there will be v5, maybe v6 etc. Although "NO!!!! No more huge patch bombs to linux-kernel@vger.kernel.org people!" was removed, but its spirit is kind of still valid and requesting to rebase cleanups on top of patch bombs with new features is just not reasonable. Best regards, Krzysztof