From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24E9830DED1 for ; Wed, 26 Nov 2025 03:21:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764127268; cv=none; b=AUUtxykadOPp9p5f7m8Al3fKganP7xgBRZynUQq/hgsG3Dmzni5Fx620+MZRia0YW4U7kqn8ryIjhwiusyh8mXKoD7MSvNtf7Ri41FmkwmG8kjU2gvBEY2YNPRhrGZGI1SdOTZ/m9TNmdT4MYn0YRUeyaFrla9+yteremKQZps8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764127268; c=relaxed/simple; bh=PMiQeEd98Cjd00Y+TKpISiWumSMgViPvAgwPAQmd3nQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gs7EpxbcZSU26mgD+m3rSJQUMK9II5r+eTopq5RLuC+qyQEtz1Tqrulr6mZhzeXrVSzOvdGlHgCrbAGetQ9yQPb8OVG4TnKGrTRxGQPpexXBFjJXVvlQ2HM+J6wmIJo+ZVYJUo+P7BufwRfp/INn8+4poJduK6QMcnULqrXt1c0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kkUQofnj; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jpWUpgvE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kkUQofnj"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jpWUpgvE" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5APNmgS33317510 for ; Wed, 26 Nov 2025 03:21:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pUSij966+HRiUH0i/n3DzHvXFNJRC2P5sPL2WyUURiI=; b=kkUQofnjt5WDQGaa hDSbJQvYF9Hqo/CIzg89Tud5/GIlC9KofKQZ7Gt2X/gXx2UZTd9oyVaNTtAIP0YJ Xdxy8n08L+RKfkfloxLk0+pYhCkCHWGKkQDJlpG+mWPXAICTW0uypgZITDq1YVlc f5CUr6hHxny324cDx1Fg+QRxOY/Nwx7FTxNMOWd/CC90jLkb5Fvam220sffIikUq sGKfKqa/QTNACvyVTAaCgLEMe9u+WZlb26zEkXhvMY2U0gNqhfXEvuJ6y+a0hTKU f3RQUsdl5T6NzOkaFHEuECvVKjdujUkjql2Zve9A96FEsZtD7FZYZxy/qGxM/NNi 8VC8CA== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4and2qj3th-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 26 Nov 2025 03:21:04 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-b630753cc38so10403504a12.1 for ; Tue, 25 Nov 2025 19:21:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1764127264; x=1764732064; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pUSij966+HRiUH0i/n3DzHvXFNJRC2P5sPL2WyUURiI=; b=jpWUpgvE+YrEmmFfc/Gja6VCpdTNUaeGod2GJFO3XfR/2zn4GR9yYJrWupKhkcK0ex E38/XSURWAFZABzCwph7EKoiywXMPbViExvZr+kkdBXFcjb1WsRhn1AiI7nWtPoac9cc M6kDyBkphFAOy2hHTVBaqgrLTjGJjbJ1xF3drRDNO72Nz9viuAMQ4n8cjWuMAWh33shh 6kwJIoV7OxeU9gwNwpWtp823E9ACch0wAZZMdIpxuM0Xd5Nb+aP0VeLDntHW7aMp13G8 rN+kj83rrKhovT8/yNM+GOF49T6fU4ItGK2eeVaVVbt14HlF5csotqxtARIJR2AqXtdg jSiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764127264; x=1764732064; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pUSij966+HRiUH0i/n3DzHvXFNJRC2P5sPL2WyUURiI=; b=Rg01n7ujOiWWXsZLJDX0yJ6rXzv6bNnbrcGOiFsmxIRZnqK05oI3in3G4Y4O0+Gwm6 MtFHPojokwtOjV4StQyDREUoc7TABaFLBh9IdgKo8G2YFbSnyIAW+rDl5raS3P4Ikhfm 2gfiRoDvBWiSpplhZzJrQ2ncCcgQFrIjsuGm7eRffE46DHnTG3GglbGD8/GJYDCmA8kq +Sa4Fz/DtusLHd2+vsQ5XdrFDa0KXh60x+K7dGdVx9ib+hj+f48vrtA+KY0iNsJi0bkx DrEzHp1I3ey7hPbTSV0B8/+RA4RWvw8kQYl42mLBKI8zK6XIVXfDl3P25SaIr0qKPmyW kW6Q== X-Forwarded-Encrypted: i=1; AJvYcCU640+AvoQ9Yair1/BCesQKsCoo03qMAj/NRDt7mn+G/cnuYU5atLjrZPuf0SAFF9fmR7RTy1fNcaN9VoU=@vger.kernel.org X-Gm-Message-State: AOJu0YxccVbqO+eC5gZwIorSEvG2cyYx8/4yboJxIBtCWwLZ6SmInipo BfKwvgd4TdkPo7F3Izx9euFy9dE5SK0byIcNdYXzt10WBKbickTTzoI3DO8x24k2Sr4MVzEMLZU YnC6ehQS3QRdrdEXmlFPTX57230KwpxyW/HJM/TiRoAvulpwEHQxhGQOtBTh4tldkz1Q= X-Gm-Gg: ASbGncu7W6/mz6/xhASAknZ9oRMsz4eEvWq8BBaxSUYIPBfT4vF8UO5//k+BJcWc5yT WAYTGU8XfB5g6C3dTFc8afIKBV8/43ObFRrPbq0X+pctrmeS1wPo9zkmbCW2PT9F6/C9wUG/tjO aGK0HzmL7J3s5DOHHqrj6lDLGDGdSVPcPU+yHDTpakJ2wxOLv1jLT/g1XFpejWIPb+0z+wSmffP X0R//YalocfbLBRWz4fTqCqWWPHq9BgNbRiXzG4qxShhJtfv3T5PuKAEqysTsOK+MZTyFhNXwiW MMbXjzpaO9w2XvzUVlRIyfieYSIUdmRi0L5xO7wwhMWbYvM37dhrqxUlEiVgEgwAzKnRALzRmEg zV5l0f0CIuPnbKdO1Z8LRjiAOXLEgjs9JtWh/8Qdi0ClvTNHJqe2ynMwdOsJLkr743t239A== X-Received: by 2002:a05:6a20:4311:b0:35b:ae01:a4cc with SMTP id adf61e73a8af0-3614eb27712mr21998832637.1.1764127263904; Tue, 25 Nov 2025 19:21:03 -0800 (PST) X-Google-Smtp-Source: AGHT+IHY5GTmXB6LRIcB/8CKQbkXtSEMjcFcfmYhsgY/Tg9UhZJyBXxtYvylvK9lnxc5BwtLpd4OJQ== X-Received: by 2002:a05:6a20:4311:b0:35b:ae01:a4cc with SMTP id adf61e73a8af0-3614eb27712mr21998793637.1.1764127263426; Tue, 25 Nov 2025 19:21:03 -0800 (PST) Received: from [10.133.33.250] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-bd775ccabfdsm17447699a12.29.2025.11.25.19.20.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Nov 2025 19:21:03 -0800 (PST) Message-ID: <48e5427b-a17f-42f6-9c04-ddba8f383d58@oss.qualcomm.com> Date: Wed, 26 Nov 2025 11:20:58 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] drm/msm/dp: fix the intf_type of MST interfaces To: Dmitry Baryshkov Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abhinav Kumar References: <20251125-mdss_catalog-v4-1-df651fba2702@oss.qualcomm.com> <3cnujrkkcui34wg3jrfoezradc5itm2paw5mgkii2d2snlac2a@lerj4ldbvf4l> Content-Language: en-US From: Yongxing Mou In-Reply-To: <3cnujrkkcui34wg3jrfoezradc5itm2paw5mgkii2d2snlac2a@lerj4ldbvf4l> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTI2MDAyNCBTYWx0ZWRfX9vQJJwvN0D6O DovoLeDBGFAvPr8a6yPj8j106OpZccoJ9008O0lbDbcRFzM27D3EoUdLmJWYfds2Dqmaxfkcg1Y Xg7wUSiyFhGcVQarztDkxkfGK64WZQDjGEftl/+isaFOvCLxRY1mnlUC2BTMxx17RgzazPoIYQz Vhhhw9OXLBh3DWsg02dYj4u9ZyLl4Ei/XlBo+0DEVBn+wnC1Gv0Nk22lD5BcsvejBvY/T0ta7ZU KsvuPVNs2BNqdahwY8+FZ1jxWZ5ilG8LsFlyvaRHyXjse4jmvbiGd1VYymq5mTLF5Gxbm/Nmw7y D0OmLvwiHjcI+7pcxUSVskSw9RCPQXliZHs4kP+Di87aAOTipcwcrkhH3xvheRRL1AUOYTvVJ3Q rrjlSaP9gVCh3GQg7o2/DpAPfYQd0g== X-Authority-Analysis: v=2.4 cv=dZyNHHXe c=1 sm=1 tr=0 ts=69267220 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=COk6AnOGAAAA:8 a=aISMk_G62U0n0vxTSHQA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-ORIG-GUID: 6YmvTQTtImwFGVUERfnqLdF54mm0jOm6 X-Proofpoint-GUID: 6YmvTQTtImwFGVUERfnqLdF54mm0jOm6 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-25_02,2025-11-25_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 spamscore=0 clxscore=1015 bulkscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511260024 On 11/26/2025 8:36 AM, Dmitry Baryshkov wrote: > On Tue, Nov 25, 2025 at 04:22:12PM +0800, Yongxing Mou wrote: >> From: Abhinav Kumar >> >> Interface type of MST interfaces is currently INTF_NONE. Update this to >> INTF_DP. And correct the intf_6 intr_underrun/intr_vsync index for >> dpu_8_4_sa8775p. >> >> Signed-off-by: Abhinav Kumar >> Signed-off-by: Yongxing Mou >> Reviewed-by: Dmitry Baryshkov >> --- >> This patch was split out from the MST V3 patch series: >> https://lore.kernel.org/all/20250825-msm-dp-mst-v3-0-01faacfcdedd@oss.qualcomm.com/ >> --- >> Changes in v4: >> - Splite chagne out from the MST V3 series. > > Why? > I would like to send out some patches that are independent and have no dependencies on the overall series, to make maintenance and review easier. For example, in V3, patches 1, 29, 33, and 37. I mentioned this approach in the first patch of V3 before. Please let me know if this is appropriate. If not, I will stop immediately. >> - Link to v3: https://lore.kernel.org/all/20250825-msm-dp-mst-v3-37-01faacfcdedd@oss.qualcomm.com/ >> >> Changes in v3: >> - Fix through the whole catalog >> - Link to v2: https://lore.kernel.org/all/20250609-msm-dp-mst-v2-37-a54d8902a23d@quicinc.com/ >> >> Changes in v2: >> - Change the patch order in the series. >> - Link to v1: https://lore.kernel.org/all/20241205-dp_mst-v1-3-f8618d42a99a@quicinc.com/ >> --- >> drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_0_sc8280xp.h | 6 +++--- >> drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_8_4_sa8775p.h | 12 ++++++------ >> drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_9_2_x1e80100.h | 6 +++--- >> 3 files changed, 12 insertions(+), 12 deletions(-) >> >> @@ -363,15 +363,15 @@ static const struct dpu_intf_cfg sa8775p_intf[] = { >> }, { >> .name = "intf_6", .id = INTF_6, >> .base = 0x3A000, .len = 0x280, >> - .type = INTF_NONE, >> + .type = INTF_DP, >> .controller_id = MSM_DP_CONTROLLER_0, /* pair with intf_0 for DP MST */ >> .prog_fetch_lines_worst_case = 24, >> - .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 17), >> - .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 16), >> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 16), >> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 17), > > This is a separate fix, it should be a separate patch. > Got that, thanks..