From: Quentin Monnet <quentin@isovalent.com>
To: Wang Hai <wanghai38@huawei.com>,
ast@kernel.org, daniel@iogearbox.net, kafai@fb.com,
songliubraving@fb.com, yhs@fb.com, andrii@kernel.org,
john.fastabend@gmail.com, kpsingh@chromium.org, toke@redhat.com,
danieltimlee@gmail.com
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf] tools: bpftool: Add missing close before bpftool net attach exit
Date: Mon, 9 Nov 2020 10:07:22 +0000 [thread overview]
Message-ID: <48e85eae-659b-9116-35c8-e4e01a8c05b6@isovalent.com> (raw)
In-Reply-To: <20201109070410.65833-1-wanghai38@huawei.com>
On 09/11/2020 07:04, Wang Hai wrote:
> progfd is created by prog_parse_fd(), before 'bpftool net attach' exit,
> it should be closed.
>
> Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP on interface")
> Signed-off-by: Wang Hai <wanghai38@huawei.com>
Reviewed-by: Quentin Monnet <quentin@isovalent.com>
Thanks!
Quentin
next prev parent reply other threads:[~2020-11-09 10:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 7:04 Wang Hai
2020-11-09 10:07 ` Quentin Monnet [this message]
2020-11-09 10:51 ` Michal Rostecki
2020-11-09 21:37 ` John Fastabend
2020-11-10 1:57 ` wanghai (M)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48e85eae-659b-9116-35c8-e4e01a8c05b6@isovalent.com \
--to=quentin@isovalent.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=danieltimlee@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=toke@redhat.com \
--cc=wanghai38@huawei.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®