From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D199C433EF for ; Tue, 22 Feb 2022 10:23:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230281AbiBVKYJ (ORCPT ); Tue, 22 Feb 2022 05:24:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229648AbiBVKYH (ORCPT ); Tue, 22 Feb 2022 05:24:07 -0500 Received: from imap3.hz.codethink.co.uk (imap3.hz.codethink.co.uk [176.9.8.87]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D46F283013; Tue, 22 Feb 2022 02:23:42 -0800 (PST) Received: from cpc152649-stkp13-2-0-cust121.10-2.cable.virginm.net ([86.15.83.122] helo=[192.168.0.21]) by imap3.hz.codethink.co.uk with esmtpsa (Exim 4.92 #3 (Debian)) id 1nMSKW-0005am-Cx; Tue, 22 Feb 2022 10:23:36 +0000 Message-ID: <48e917d1-c012-29bc-d3be-b9ccb876a074@codethink.co.uk> Date: Tue, 22 Feb 2022 10:23:35 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [[PATCHv3]] PCI: fu740: Force gen1 for initial device probe Content-Language: en-GB To: paul.walmsley@sifive.com, greentime.hu@sifive.com Cc: lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com, bhelgaas@google.com, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org References: <20220221203803.1333012-1-ben.dooks@codethink.co.uk> From: Ben Dooks Organization: Codethink Limited. In-Reply-To: <20220221203803.1333012-1-ben.dooks@codethink.co.uk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/02/2022 20:38, Ben Dooks wrote: > The fu740 PCIe core does not probe any devices on the SiFive Unmatched > board without this fix from U-Boot (or having U-Boot explicitly start > the PCIe via either boot-script or user command). > > The fix claims to set the link-speed to gen1 to get the probe > to work. As this is a copy from U-Boot, the code is assumed to be > correct and does fix the issue on the Unmatched. The code is at: > https://source.denx.de/u-boot/u-boot/-/blob/master/drivers/pci/pcie_dw_sifive.c#L271 > > The code has been this way since the driver was commited in: > https://source.denx.de/u-boot/u-boot/-/commit/416395c772018c6bf52aad36aca163115001793f > Apologies everyone, messed up sending v3 so re-sent as v4. -- Ben Dooks http://www.codethink.co.uk/ Senior Engineer Codethink - Providing Genius https://www.codethink.co.uk/privacy.html