From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Heiko Stübner" <heiko@sntech.de>,
"Quentin Schulz" <foss+kernel@0leil.net>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Quentin Schulz <quentin.schulz@theobroma-systems.com>
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: remove duplicate SPI aliases for helios64
Date: Tue, 9 Jan 2024 20:14:38 +0100 [thread overview]
Message-ID: <48f1b3cb-0a98-4b14-89f6-e1ca6b858512@linaro.org> (raw)
In-Reply-To: <2258938.QZUTf85G27@diego>
On 09/01/2024 16:23, Heiko Stübner wrote:
> Am Dienstag, 9. Januar 2024, 16:16:15 CET schrieb Krzysztof Kozlowski:
>> On 09/01/2024 14:35, Quentin Schulz wrote:
>>> From: Quentin Schulz <quentin.schulz@theobroma-systems.com>
>>>
>>> An earlier commit defined an alias for all SPI controllers found on the
>>> RK3399, so there's no need to duplicate the aliases in helios64's device
>>> tree.
>>
>> That's not what we want. Boards should define aliases for what is
>> available, according to the board labeling.
>
> and the board labeling for spi2 has always been spi2-miso, spi2-miso etc.
> In the last 10 years of doing Rockchip stuff, I haven't seen any schematic
> doing it differently.
OK, this could be a case... but then you add aliases for things which
are not labeled on the board.
Let's bring Arnd again:
https://lore.kernel.org/linux-rockchip/CAK8P3a0ALgbhTVJ7t3XRXALs9vBM=XBvkGhNKXxB+QTepo-3AQ@mail.gmail.com/
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-09 19:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 13:35 [PATCH 0/2] arm64: dts: rockchip: add SPI controller aliases to RK3399 Quentin Schulz
2024-01-09 13:35 ` [PATCH 1/2] arm64: dts: rockchip: add spi controller aliases on rk3399 Quentin Schulz
2024-01-09 15:15 ` Krzysztof Kozlowski
2024-01-09 15:22 ` Heiko Stübner
2024-01-09 16:14 ` Dragan Simic
2024-01-09 19:13 ` Krzysztof Kozlowski
2024-01-09 13:35 ` [PATCH 2/2] arm64: dts: rockchip: remove duplicate SPI aliases for helios64 Quentin Schulz
2024-01-09 15:16 ` Krzysztof Kozlowski
2024-01-09 15:23 ` Heiko Stübner
2024-01-09 19:14 ` Krzysztof Kozlowski [this message]
2024-01-10 11:18 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48f1b3cb-0a98-4b14-89f6-e1ca6b858512@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=foss+kernel@0leil.net \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=quentin.schulz@theobroma-systems.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®