From: Robin Murphy <robin.murphy@arm.com>
To: Jilin Yuan <yuanjilin@cdjrlc.com>,
airlied@linux.ie, daniel@ffwll.ch,
krzysztof.kozlowski@linaro.org
Cc: dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/exynos: fix repeated words in comments
Date: Tue, 23 Aug 2022 14:36:56 +0100 [thread overview]
Message-ID: <48f4a56f-0586-9e9d-c121-6309be65b803@arm.com> (raw)
In-Reply-To: <20220823122117.15757-1-yuanjilin@cdjrlc.com>
On 2022-08-23 13:21, Jilin Yuan wrote:
> Delete the redundant word 'next'.
From the context, I'm not sure it is redundant - as far as I can tell
this comment seems to be describing a sequence of 3 commands, where
"current" is the first, "next" is the second, and "next next" implies
the third. The whole comment could certainly be reworded more clearly,
but as it stands I suspect a replacement like s/next next/next+1/ is
more likely to be correct.
Robin.
> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
> ---
> drivers/gpu/drm/exynos/exynos_drm_g2d.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> index 471fd6c8135f..4f9edca66632 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c
> @@ -1195,7 +1195,7 @@ int exynos_g2d_set_cmdlist_ioctl(struct drm_device *drm_dev, void *data,
> * If don't clear SFR registers, the cmdlist is affected by register
> * values of previous cmdlist. G2D hw executes SFR clear command and
> * a next command at the same time then the next command is ignored and
> - * is executed rightly from next next command, so needs a dummy command
> + * is executed rightly from next command, so needs a dummy command
> * to next command of SFR clear command.
> */
> cmdlist->data[cmdlist->last++] = G2D_SOFT_RESET;
next prev parent reply other threads:[~2022-08-23 17:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-23 12:21 Jilin Yuan
2022-08-23 12:34 ` Krzysztof Kozlowski
2022-08-23 13:36 ` Robin Murphy [this message]
2022-08-24 11:39 ` Inki Dae
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=48f4a56f-0586-9e9d-c121-6309be65b803@arm.com \
--to=robin.murphy@arm.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=yuanjilin@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®