mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ryan Hope" <rmh3093@gmail.com>
To: "Dmitry Adamushko" <dmitry.adamushko@gmail.com>
Cc: "james toy" <unk.nown@unix.net>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	"Vegard Nossum" <vegard.nossum@gmail.com>
Subject: Re: [-mmotm] BUG: scheduling while atomic: swapper
Date: Tue, 26 Aug 2008 10:15:25 -0400	[thread overview]
Message-ID: <48f7fe350808260715y30ef89a1le7f8abdf0be61351@mail.gmail.com> (raw)
In-Reply-To: <b647ffbd0808260302r1d50dbacr3595d160e0203ce3@mail.gmail.com>

Thanks for getting back to me on this guys.  Yes I am using mmotm, the
daily -mm broken out tree... THe bug happens while booting, and it
shows up many times. Anyway I checked microcode_intel.c and the
function in question looks like this:

static int __init microcode_intel_module_init(void)
{
       struct cpuinfo_x86 *c = &cpu_data(get_cpu());

       if (c->x86_vendor == X86_VENDOR_INTEL)
               return microcode_init(&microcode_intel_ops, THIS_MODULE);
       else
               return -ENODEV;
}

I will try the changes in he patch in Jame's post.... and report back. THanks.

-Ryan

On Tue, Aug 26, 2008 at 6:02 AM, Dmitry Adamushko
<dmitry.adamushko@gmail.com> wrote:
> 2008/8/26 james toy <unk.nown@unix.net>:
>> Andrew,
>>
>> Yes, ours does look like this -- however when i checked the git diff on git
>> web i found:
>>
>> index d2d9d74..6dd8907 100644 (file)
>> --- a/arch/x86/kernel/microcode_intel.c
>> +++ b/arch/x86/kernel/microcode_intel.c
>> @@ -531,12 +531,14 @@ static struct microcode_ops microcode_intel_ops = {
>>
>>  static int __init microcode_intel_module_init(void)
>>  {
>> -       struct cpuinfo_x86 *c = &cpu_data(get_cpu());
>> +       struct cpuinfo_x86 *c = &cpu_data(0);
>
> (err... I'm a bit confused by the use of "fixed" here. The snippet
> posted by Andrew illustrates how it was _before_ the fix,
> i.e. it's the version that causes the "scheduling while atomic" bug).
>
> IOW, If your local version has cpu_data(get_cpu()) in
> microcode_intel_module_init(), then it explains the trace you have
> observed. That also means you are not up-to-date with -next.
>
>
> --
> Best regards,
> Dmitry Adamushko
>

  reply	other threads:[~2008-08-26 14:15 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-26  2:09 Ryan Hope
2008-08-26  6:37 ` Andrew Morton
2008-08-26  7:01   ` Vegard Nossum
2008-08-26  8:11 ` Dmitry Adamushko
2008-08-26  8:24   ` Andrew Morton
     [not found]     ` <9f8af95f0808260225u162da49aj1d6f6fd9db79499f@mail.gmail.com>
2008-08-26  9:29       ` james toy
2008-08-26 10:02       ` Dmitry Adamushko
2008-08-26 14:15         ` Ryan Hope [this message]
2008-08-26 14:53           ` Ryan Hope
2008-08-26 14:58             ` Ryan Hope

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=48f7fe350808260715y30ef89a1le7f8abdf0be61351@mail.gmail.com \
    --to=rmh3093@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dmitry.adamushko@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=unk.nown@unix.net \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®