From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751315AbeABSKx (ORCPT + 1 other); Tue, 2 Jan 2018 13:10:53 -0500 Received: from merlin.infradead.org ([205.233.59.134]:53346 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751034AbeABSKu (ORCPT ); Tue, 2 Jan 2018 13:10:50 -0500 Subject: Re: [PATCH] i2c: fix ACPI_I2C_OPREGION dependency To: Sinan Kaya , Eric Auger , eric.auger.pro@gmail.com, wsa@the-dreams.de, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, "linux-acpi@vger.kernel.org" References: <1511370357-17184-1-git-send-email-eric.auger@redhat.com> From: Randy Dunlap Message-ID: <48ff2e75-5ee0-5ac9-8d47-58c3c691ad6e@infradead.org> Date: Tue, 2 Jan 2018 10:10:47 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On 01/02/2018 10:07 AM, Sinan Kaya wrote: > +linux-acpi > > On 11/22/2017 12:05 PM, Eric Auger wrote: >> If CONFIG_I2C=m we fail getting ACPI_I2C_OPREGION set. Let's >> make ACPI_I2C_OPREGION depend on I2C. >> >> Signed-off-by: Eric Auger >> --- >> drivers/i2c/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig >> index efc3354..5951e9d 100644 >> --- a/drivers/i2c/Kconfig >> +++ b/drivers/i2c/Kconfig >> @@ -26,7 +26,7 @@ config I2C >> >> config ACPI_I2C_OPREGION >> bool "ACPI I2C Operation region support" >> - depends on I2C=y && ACPI >> + depends on I2C && ACPI >> default y >> help >> Say Y here if you want to enable ACPI I2C operation region support. >> > > Anybody picking this up? Well. It looks to me like the patch is reversed or the patch description needs some improvement. Or I just don't understand it. -- ~Randy