From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757241AbbLAWqc (ORCPT ); Tue, 1 Dec 2015 17:46:32 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:57375 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756927AbbLAWqa convert rfc822-to-8bit (ORCPT ); Tue, 1 Dec 2015 17:46:30 -0500 From: Arnd Bergmann To: Krzysztof =?utf-8?B?SGHFgmFzYQ==?= Cc: Imre Kaloz , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: ixp4xx: fix read{b,w,l} return types Date: Tue, 01 Dec 2015 23:46:03 +0100 Message-ID: <4900418.HEVAcnQtkC@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: <4577677.sEiIMqkHSM@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" X-Provags-ID: V03:K0:sFETNJs1jF14R49ukFXHjXsZdoOryuFtxZgqqS/50S9yrh+MhD2 vYc7NTkGBFst3DwbIGULei5flu/H2+fWX7UH3K3WTKOq2oQ6hFnaW+9EC0kSMv8FGAGB6Nc 4y+Oh3KFZTRMy/OYgDR9q9hxt54K9J1J27s8VcJcZHzI06gwmZSaDJytSa5X/c9HL5YIygr 7u5wDdz077w7QaE3Y/2xQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:R12ayA6rGRw=:d3p26iodbyGZli/aWfB3dM Mhe/l1gKYKKQ+qQRANkc4QJayT/IChRGjKeoWvHnfQwFF7Fg6W7bWfeWn7KMBoNwSf++IHc+2 ruPgtOG4sPTHq8N6koLP0rstXXNEINrRtPjHaAUvN2AGe3fThsLpT2BcuV/9jHMSSRvMHpYpn mkCgmPiCfcQLgUjaxiQILXBHjmB8f3zf2/0PYLzb8ZtsCFFqe4sVGoBNlj9SnvVIPGyqOYk/c PUeyuS7LPFJUExus/ZVR29oPG9PR+tmPtbozjVdyfQTUAqe24cKLB0XDxNzCe1aJAlSM02bcG yzXsQ2MSUPXXv1aV9dLKs1ek1v7UzBMNnDAl8THb4qc01RadEwrdIZiuR0KF4kxPDsWboY+d/ mZHFrRGhC/YaNW5h4WlRcoFLg+G11j0KdObyFFBrjn22qUnIDvjAhgxg3cfy3If1rvIlhmq+W nTgYovMkhOy4QHQ0zTDB6/6XO4Xb0y0mfuyRghCm+deYCnPZP1PldRALJwPFOvmwiGmdZgfkN /1mNZW2w5zck3g9qNe1ssdgELwvRlgAZ2v8IDeP7i54L7nQbDTVUhJSOhvn9wvsogQ7S/QG6Z ZvZUu4fUG4vM++i+MYb6j+zShZlBf0is6uM6CXXu6fuqD28w2O5i+lL6wJ8KZQn8yPYN1qjx+ 3uHUFWZLm8tOAwP94WPYfZHNpzR0CclVZEZtMOwIriRnlRXVWk9O/fDii9lxT4lBru7Ro+9Ra 292yeE0nGL8A77Yg Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 25 November 2015 13:31:16 Krzysztof HaƂasa wrote: > Arnd Bergmann writes: > > > On ixp4xx, the readl() function returns an 'unsigned long' output > > when indirect I/O is used. This is unlike any other platform, and > > it causes lots of harmless compiler warnings, such as: > > > > drivers/ata/libahci.c: In function 'ahci_show_host_version': > > drivers/ata/libahci.c:254:22: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int' [-Wformat=] > > drivers/block/mtip32xx/mtip32xx.c: In function 'mtip_hw_read_registers': > > drivers/block/mtip32xx/mtip32xx.c:2602:31: warning: format '%X' expects argument of type 'unsigned int', but argument 3 has type 'long unsigned int' [-Wformat=] > > drivers/block/cciss.c: In function 'print_cfg_table': > > drivers/block/cciss.c:3845:25: warning: format '%d' expects argument of type 'int', but argument 4 has type 'long unsigned int' [-Wformat=] > > > > This changes all six of the ixp4xx specific I/O read functions > > to return the same types that we have in the normal asm/io.h, > > to avoid the warnings. > > Thanks for fixing this. > > Acked-by: Krzysztof Halasa > Applied to fixes for 4.4 now with your ack.