From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5550DC433DF for ; Tue, 14 Jul 2020 08:13:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35DC1217D8 for ; Tue, 14 Jul 2020 08:13:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726431AbgGNINm (ORCPT ); Tue, 14 Jul 2020 04:13:42 -0400 Received: from host-88-217-225-28.customer.m-online.net ([88.217.225.28]:33747 "EHLO mail.dev.tdt.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725816AbgGNINl (ORCPT ); Tue, 14 Jul 2020 04:13:41 -0400 X-Greylist: delayed 388 seconds by postgrey-1.27 at vger.kernel.org; Tue, 14 Jul 2020 04:13:41 EDT Received: from mail.dev.tdt.de (localhost [IPv6:::1]) by mail.dev.tdt.de (Postfix) with ESMTP id 373D420D83; Tue, 14 Jul 2020 08:07:10 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 14 Jul 2020 10:07:10 +0200 From: Martin Schiller To: Xie He Cc: "David S. Miller" , Jakub Kicinski , Heiner Kallweit , Shannon Nelson , Martin Habets , "Michael S. Tsirkin" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Linux X25 Subject: Re: [PATCH] drivers/net/wan/x25_asy: Fix to make it work Organization: TDT AG In-Reply-To: References: <20200708043754.46554-1-xie.he.0141@gmail.com> <20200708.101321.1049330296069021543.davem@davemloft.net> Message-ID: <490146353e9225245d8165b6edade1a9@dev.tdt.de> X-Sender: ms@dev.tdt.de User-Agent: Roundcube Webmail/1.1.5 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-07-08 21:04, Xie He wrote: > From: David Miller > Date: Wed, Jul 8, 2020 at 10:13 AM -0700 >> Something's not right, because I find it hard to believe this has been >> so fundamentally broken for such a long period of time. >> >> Maybe the drivers all handle things differently, and whilst your >> change >> might fix some drivers, it will break others. >> >> I'm not applying this until this situation is better understood. > > Yes, it was hard for me to believe, too. > > At first when I tried this driver, it was silently not able to > establish > LAPB connections, I found that it was because it was ignoring > 2-byte frames. I changed it to make 2-byte frames pass. Then I > encountered kernel panic. I don't know how to solve it, so I looked > at the way "lapbether" does things and changed this driver according > to the "lapbether" driver. And it worked. > > The "lapbether" driver and this driver both use the "lapb" module to > implement the LAPB protocol, so they should implement LAPB-related > code in the same way. > > This patch only changes this driver and does not affect other drivers. > > I don't know how I can better explain this situation. Please tell me > anything I can do to help. Thanks! It really seems very strange that this driver seems to contain such fundamental errors. I have never used it. But the explanations and fixes look plausible to me.