From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9445C4360C for ; Sun, 6 Oct 2019 04:23:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB1B12067B for ; Sun, 6 Oct 2019 04:23:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726131AbfJFEX1 (ORCPT ); Sun, 6 Oct 2019 00:23:27 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3248 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726086AbfJFEX0 (ORCPT ); Sun, 6 Oct 2019 00:23:26 -0400 Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id CFB20F71EDA02A3BA95B; Sun, 6 Oct 2019 12:23:23 +0800 (CST) Received: from [127.0.0.1] (10.133.213.239) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.439.0; Sun, 6 Oct 2019 12:23:20 +0800 Subject: Re: [RFC PATCH] scripts: Fix coccicheck failed To: Masahiro Yamada , Julia Lawall References: <20190928094245.45696-1-yuehaibing@huawei.com> <2c109d6b-45ad-b3ca-1951-bde4dac91d2a@huawei.com> CC: Gilles Muller , Nicolas Palix , Michal Marek , "Matthias Maennich" , Greg Kroah-Hartman , Linux Kernel Mailing List , Coccinelle From: Yuehaibing Message-ID: <490422f5-e33f-3aab-ba2d-747b9fecca91@huawei.com> Date: Sun, 6 Oct 2019 12:23:18 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019/10/4 10:32, Masahiro Yamada wrote: > On Thu, Oct 3, 2019 at 9:23 PM Julia Lawall wrote: >> >> >> >> On Thu, 3 Oct 2019, Masahiro Yamada wrote: >> >>> On Tue, Oct 1, 2019 at 10:01 PM Julia Lawall wrote: >>>>> diff --git a/scripts/coccinelle/misc/add_namespace.cocci b/scripts/coccinelle/misc/add_namespace.cocci >>>>> index c832bb6445a8..99e93a6c2e24 100644 >>>>> --- a/scripts/coccinelle/misc/add_namespace.cocci >>>>> +++ b/scripts/coccinelle/misc/add_namespace.cocci >>>>> @@ -6,6 +6,8 @@ >>>>> /// add a missing namespace tag to a module source file. >>>>> /// >>>>> >>>>> +virtual report >>>>> + >>>>> @has_ns_import@ >>>>> declarer name MODULE_IMPORT_NS; >>>>> identifier virtual.ns; >>>>> >>>>> >>>>> >>>>> Adding virtual report make the coccicheck go ahead smoothly. >>>> >>>> Acked-by: Julia Lawall >>>> >>> >>> >>> Was this patch posted somewhere? >> >> It was probably waiting for moderation in the cocci mailing list. Do you >> have it now (or in a few minutes)? > > No. I do not see it yet. > > I want to pick the patch from LKML Patchwork > https://lore.kernel.org/patchwork/project/lkml/list/ > > You gave Acked-by to the one-liner fix "virtual report", > and I am happy to apply it to my tree. > > YueHaibing, could you submit it as a patch? Sorry for late, will send it. > >