From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92050236A97 for ; Tue, 14 Jan 2025 12:46:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736858815; cv=none; b=nVbPvH9fMMqZh8k4N320/faPs9CbsR4Vl47KrCDGeQMWZ2yErJAUIr1DJ0EdWsBeIJZ9KsTzPPjLpmF2RYmQ2yUe6aHBFzx7NBVtgJmLqmLnQOrHdoOp+hpXzx2k4PLR2VeIYhaHJ7iF2KhvSOsT05lF2dxNCrRRNOqCo/0t0Gc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736858815; c=relaxed/simple; bh=Uin1dOmwdUP+SHUBgd6PscEgsxreyrFU/vwVc8g8y7M=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=h1YLzrq/zxrtIxm1UaNBsgzwLiPujuKpiyNsnk+TvJpd5zbwy8CLi7Og4FW+RTCwUw6E69sdQxIocKJw3gII1ejjpnF3IPxfXnN2W5PaVjhP17FN4x8Z/AI7AKc1KC8r9zfA/efnbrYbbitZY5VYdEmx16mws0EB2FWpjUUlAhw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=T0LmrXx7; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="T0LmrXx7" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1736858812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kH/iRgPgE7A5Fhhf2p8dKe9HdDfKM5Ah+Fq/yovw5X4=; b=T0LmrXx7ia/DwHp3WdAoYMtcxB7cE7yXUAZEBcSz0xpqMQuG0UxsAbVozogH0/cHNpBCw/ MZH8qrSstSGlwMIAJAqul/bprabAsa1mrwfEVxiq61/JhUyoeqrTODVNIT/15ITmLii9a+ cWdK23ULDdfZlAbw3xyfzQeV15R9nfg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-475-hycia4TIOSG23MIYuzsNuw-1; Tue, 14 Jan 2025 07:46:51 -0500 X-MC-Unique: hycia4TIOSG23MIYuzsNuw-1 X-Mimecast-MFC-AGG-ID: hycia4TIOSG23MIYuzsNuw Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-385d80576abso3638917f8f.3 for ; Tue, 14 Jan 2025 04:46:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736858810; x=1737463610; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kH/iRgPgE7A5Fhhf2p8dKe9HdDfKM5Ah+Fq/yovw5X4=; b=h1RWHZhTtSZG4I7J0g82/QecwQHRPttaQe17hZFVeB5wMXgJTVbDy1s9ymGybrkcrx yVQN6QdnqKQab3v5JCVIO7b6Uj5zvw15cDTopHIt4p7nbInYsdBuNGqUA/izzZe7HVbi 9wZjKhqMTVquWWyEhaNMGkhSaPtqp4+MxUXPSfvuntk+vhRu7q3xkVkOyf+ySTwMXj1a KVlSLQWaWl+Yh9+kCqE+98g6GmgnXxi6mDadfpYdIoPjGK5J+Bm+4XrX2UxhswUu7sqe +B+q4KkkS3uNVWJqC4y+BciApD/FVmKsmvWEWhSwP9vpZW6BfH1qIrUA4lw1oYaSltwD chug== X-Forwarded-Encrypted: i=1; AJvYcCVmLuDvZb9UMaCqWGtPwQ3D167cA/EkEhgk6sbrtFCn453hf1+T8lt34Prn/KdN6WVWYUV4lnWZ3N33rAs=@vger.kernel.org X-Gm-Message-State: AOJu0YyLhsaVjtMqmNnrSQGOTIJ2y5z8Sx/vWPRAXyGtzBfY2cqyIojh wuz6BBI+QrWTBiumM1cpuuj7DE0OBHD7Emd9F8KdJGMqvQPdFmV1hEYL0IqFBQuttQU489KPvjP mzjy5kCQKk8cyjqalWJEha0qEuQZDyxT57glmHn5iQYDd7P12NSjeba4C3QGrTg== X-Gm-Gg: ASbGncvfNsd59Swj2C5I1F6hmh8j/psbd8QT5/WR8Y2vooBbQCcjZlIjHWnJ6OoGOrM CxLwu4pEtc+PQDMh1WIkDh9I59FVhXXwEPkbzhaz0i036uWsWTL9swy9tCjgnbFtGXEInU4/kTN P92WdwTbwwShtk9911d5q4aMcxUX7WLYuP9dqDbF6W11OCAcU3Zvla3rgBtfKCpZNwZK+QhDESZ s80IG9udLiQ9IBo8k8s21fz5pseQtOGucc8tYToRMkHzidJ7r3rfl/9GeoLYN0ho4cgHxASIZ3B KxzlqApkexY= X-Received: by 2002:a05:6000:4a06:b0:385:d7f9:f157 with SMTP id ffacd0b85a97d-38a87338df5mr20454007f8f.36.1736858810303; Tue, 14 Jan 2025 04:46:50 -0800 (PST) X-Google-Smtp-Source: AGHT+IE+9v10x1N2wFoQ1EghG8MZMb2tc7d0Q08/8q5FSV+ZT6GN8dur266nKm/Vs31WmKlGP+I9ZA== X-Received: by 2002:a05:6000:4a06:b0:385:d7f9:f157 with SMTP id ffacd0b85a97d-38a87338df5mr20453986f8f.36.1736858809912; Tue, 14 Jan 2025 04:46:49 -0800 (PST) Received: from [192.168.88.253] (146-241-15-169.dyn.eolo.it. [146.241.15.169]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436e9d26a7bsm180090335e9.0.2025.01.14.04.46.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 04:46:49 -0800 (PST) Message-ID: <49043623-f34e-4274-ab4d-494d8319cb32@redhat.com> Date: Tue, 14 Jan 2025 13:46:48 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [net-next PATCH v3 3/6] octeontx2-pf: AF_XDP zero copy receive support To: Suman Ghosh , horms@kernel.org, sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com, hkelam@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, lcherian@marvell.com, jerinj@marvell.com, john.fastabend@gmail.com, bbhushan2@marvell.com, hawk@kernel.org, andrew+netdev@lunn.ch, ast@kernel.org, daniel@iogearbox.net, bpf@vger.kernel.org References: <20250110093807.2451954-1-sumang@marvell.com> <20250110093807.2451954-4-sumang@marvell.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20250110093807.2451954-4-sumang@marvell.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/10/25 10:38 AM, Suman Ghosh wrote: > @@ -1337,8 +1358,12 @@ void otx2_aura_pool_free(struct otx2_nic *pfvf) > pool = &pfvf->qset.pool[pool_id]; > qmem_free(pfvf->dev, pool->stack); > qmem_free(pfvf->dev, pool->fc_addr); > - page_pool_destroy(pool->page_pool); > - pool->page_pool = NULL; > + if (pool->page_pool) { > + page_pool_destroy(pool->page_pool); > + pool->page_pool = NULL; > + } It looks like the above delta is not needed: page_pool_destroy() handles correctly NULL value for the page pool. /P