From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755633AbbDKUlo (ORCPT ); Sat, 11 Apr 2015 16:41:44 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:49674 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753697AbbDKUlm (ORCPT ); Sat, 11 Apr 2015 16:41:42 -0400 From: Arnd Bergmann To: Johannes Berg Cc: "David S. Miller" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/wireless: CFG80211_WEXT_EXPORT requires wireless extensions Date: Sat, 11 Apr 2015 22:41:37 +0200 Message-ID: <4904912.VjuX4Pm71s@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1428733011.2139.1.camel@sipsolutions.net> References: <2303996.H1mYPouv05@wuerfel> <1428733011.2139.1.camel@sipsolutions.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:k6sLxViYAEGIGG9xTvnYZ115agYUEQG7s93umJCmQxVFord6nof JtZWN5ePl7NQe2Mp1WFE9g0GhGLeWNwnoeajVwCS3q5oIj8gTJN4ib9DTcdzUdPvv/ZAEyB NCDVVN7q/iOMndcMlDYgZy7GQCueWptANeg1G+U58tkZXJ+kcRdR+J3Umj8cOCn1q7ciHn9 OoMOwdJXHazC4Bmfw2BkA== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 11 April 2015 08:16:51 Johannes Berg wrote: > On Sat, 2015-04-11 at 00:29 +0200, Arnd Bergmann wrote: > > The CFG80211_WEXT_EXPORT symbol is selected by two drivers that > > make direct use of compat handlers for the wireless ioctls. > > However, this has no effect when the wireless extensions themselves > > are disabled, and results in a link error: > > > > ERROR: "cfg80211_wext_giwrts" [drivers/net/wireless/orinoco/orinoco.ko] undefined! > > ERROR: "cfg80211_wext_siwfrag" [drivers/net/wireless/orinoco/orinoco.ko] undefined! > > ERROR: "cfg80211_wext_giwname" [drivers/net/wireless/ipw2x00/ipw2200.ko] undefined! > > > > This changes the Kconfig logic so that CFG80211_WEXT can not > > be disabled when CFG80211_WEXT_EXPORT is set. > > > +++ b/net/wireless/Kconfig > > @@ -178,7 +178,6 @@ config CFG80211_WEXT > > bool "cfg80211 wireless extensions compatibility" > > (I added "if !CFG80211_WEXT_EXPORT" to this line) Right, that works just as well, thanks! > > depends on CFG80211 > > select WEXT_CORE > > - default y if CFG80211_WEXT_EXPORT > > help > > Enable this option if you need old userspace for wireless > > extensions with cfg80211-based drivers. > > @@ -186,6 +185,7 @@ config CFG80211_WEXT > > config CFG80211_WEXT_EXPORT > > bool > > depends on CFG80211 > > + select CFG80211_WEXT > > This doesn't work afaict because select won't go through if this is > selected. I've already sent a fix for this in my latest pull request > that has the above. As Paul commented, it does work, and I have of course checked that my patch fixes the problem without introducing other build failures. Arnd