From: Mike Travis <travis@sgi.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Jack Steiner <steiner@sgi.com>, LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 1/1] SGI x86 UV: Use raw_smp_processor_id
Date: Mon, 27 Oct 2008 11:46:50 -0700 [thread overview]
Message-ID: <49060C9A.5060807@sgi.com> (raw)
In-Reply-To: <20081027180616.GG3046@elte.hu>
Subject: SGI x86 UV: Use raw_smp_processor_id
> one small comment:
>
>> + /* is this cpu idle? */
>> + if (idle_cpu(smp_processor_id()))
>> bits &= ~SCIR_CPU_ACTIVITY;
>
> were you ever to run an -rt kernel on that hardware, this would
> produce a warning. raw_smp_processor_id() would be more appropriate i
> guess.
Thanks for the heads up! Yes, -rt is supported. Might as well avoid that
problem now.
Signed-of-by: Mike Travis <travis@sgi.com>
---
arch/x86/kernel/genx2apic_uv_x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- test-tip-latest.orig/arch/x86/kernel/genx2apic_uv_x.c
+++ test-tip-latest/arch/x86/kernel/genx2apic_uv_x.c
@@ -372,7 +372,7 @@ static void uv_heartbeat(unsigned long i
bits ^= SCIR_CPU_HEARTBEAT;
/* is this cpu idle? */
- if (idle_cpu(smp_processor_id()))
+ if (idle_cpu(raw_smp_processor_id()))
bits &= ~SCIR_CPU_ACTIVITY;
else
bits |= SCIR_CPU_ACTIVITY;
next prev parent reply other threads:[~2008-10-27 18:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-24 11:19 [PATCH 1/1] SGI X86 UV: Provide a System Activity Indicator driver Mike Travis
2008-10-24 12:01 ` Pavel Machek
2008-10-24 12:05 ` Ingo Molnar
2008-10-24 12:27 ` Mike Travis
2008-10-24 18:12 ` Andi Kleen
2008-10-24 22:18 ` Mike Travis
2008-10-24 22:24 ` Mike Travis
2008-10-27 11:42 ` Ingo Molnar
2008-10-27 14:38 ` Mike Travis
2008-10-27 14:51 ` [PATCH 1/1] SGI x86 UV: Update SCIR driver to use idle_cpu function Mike Travis
2008-10-27 18:06 ` Ingo Molnar
2008-10-27 18:46 ` Mike Travis [this message]
2008-10-25 6:56 ` [PATCH 1/1] SGI X86 UV: Provide a System Activity Indicator driver Andi Kleen
2008-10-27 15:12 ` Mike Travis
2008-10-27 11:36 ` Ingo Molnar
2008-10-27 11:43 ` Ingo Molnar
2008-10-24 12:14 ` Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49060C9A.5060807@sgi.com \
--to=travis@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome