Re:[PATCH 02/14] dt-bindings: media: add apple,avd

From: "Andy Yan" <andyshrk@163.com>
To: "Sofus Forstreuter" <sofus.c@icloud.com>
Cc: "Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Sven Peter" <sven@kernel.org>, "Janne Grunau" <j@jannau.net>,
	"Neal Gompa" <neal@gompa.dev>, "Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Heiko Stuebner" <heiko@sntech.de>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
	devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re:[PATCH 02/14] dt-bindings: media: add apple,avd
Date: Sun, 20 Sep 2026 16:10:55 +0800 (CST)	[thread overview]
Message-ID: <490c0413.5a83.1a0bdde450c.Coremail.andyshrk@163.com> (raw)
In-Reply-To: <20260918-avd-v1-2-49977931f455@icloud.com>


Hello，

At 2026-09-18 21:15:07, "Sofus Forstreuter" <sofus.c@icloud.com> wrote:
>Document the Apple Video Decoder. A hardware video decoder present on
>Apple hardware.
>
>Signed-off-by: Sofus Forstreuter <sofus.c@icloud.com>
>---
> .../devicetree/bindings/media/apple,avd.yaml       | 112 +++++++++++++++++++++
> MAINTAINERS                                        |   1 +
> 2 files changed, 113 insertions(+)
>
>diff --git a/Documentation/devicetree/bindings/media/apple,avd.yaml b/Documentation/devicetree/bindings/media/apple,avd.yaml
>new file mode 100644
>index 000000000000..34a4129d6a46
>--- /dev/null
>+++ b/Documentation/devicetree/bindings/media/apple,avd.yaml
>@@ -0,0 +1,112 @@
>+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>+%YAML 1.2
>+---
>+$id: http://devicetree.org/schemas/media/apple,avd.yaml#
>+$schema: http://devicetree.org/meta-schemas/core.yaml#
>+
>+title: Apple Video Decoder (AVD)
>+
>+description: |
>+  AVD is a stateless video decode IP block present on Apple devices.
>+  Notably it includes an ARM Cortex-M3 and associated DMA controller.
>+  AVD is capable of decoding H264, H265, VP9 and AV1 on never SoCs.

Typo： s/never/Newer？

>+
>+  The IP does not change much, with changes being mostly the CM3 having more
>+  memory and interrupts.
>+
>+maintainers:
>+  - Sofus Forstreuter <sofus.c@icloud.com>
>+
>+properties:
>+  compatible:
>+    oneOf:
>+      - items:
>+          - enum:
>+              - apple,t6030-avd
>+              - apple,t6031-avd
>+          - const: apple,t8122-avd
>+      - enum:
>+          - apple,t8103-avd
>+          - apple,t8112-avd
>+          - apple,t8122-avd
>+          - apple,t6000-avd
>+          - apple,t6020-avd
>+
>+  reg:
>+    minItems: 4
>+    items:
>+      - description: Cortex-M3 code (unsigned)
>+      - description: Cortex-M3 sram
>+      - description: Mailbox
>+      - description: Video decode control
>+      - description: DMA control
>+
>+  reg-names:
>+    items:
>+      - const: code
>+      - const: sram
>+      - const: mbox
>+      - const: ctrl
>+
>+  iommus:
>+    minItems: 1
>+    maxItems: 3
>+    description: |
>+      The block contains 3 iommus, one for decode operations, one the DMA
>+      controller can use and the last for decoding drm-protected content.
>+
>+  power-domains:
>+    maxItems: 1
>+
>+  resets:
>+    maxItems: 1
>+
>+  interrupts:
>+    minItems: 2
>+    items:
>+      - description: mailbox 0
>+      - description: mailbox 1
>+      - description: mailbox 2
>+      - description: mailbox 3
>+      - description: flag 0
>+      - description: flag 1
>+      - description: DMA status
>+    description: |
>+      Notably there are no decode related interrupts. All decode related
>+      interrupts are sent to the CM3.
>+
>+required:
>+  - compatible
>+  - reg
>+  - interrupts
>+  - reg-names
>+  - iommus
>+  - power-domains
>+  - resets
>+
>+additionalProperties: false
>+
>+examples:
>+  - |
>+    #include <dt-bindings/interrupt-controller/apple-aic.h>
>+    #include <dt-bindings/interrupt-controller/irq.h>
>+
>+    soc {
>+        #address-cells = <2>;
>+        #size-cells = <2>;
>+
>+        avd: avd@289080000 {
>+            compatible = "apple,t8122-avd";
>+            reg = <0x2 0x89080000 0x0 0x12000>,
>+                  <0x2 0x89092000 0x0 0x12000>,
>+                  <0x2 0x890a4000 0x0 0x4000>,
>+                  <0x2 0x89100000 0x0 0x10000>;
>+            reg-names = "code", "sram", "mbox", "ctrl";
>+            interrupt-parent = <&aic>;
>+            interrupts = <AIC_IRQ 679 IRQ_TYPE_LEVEL_HIGH>,
>+                         <AIC_IRQ 680 IRQ_TYPE_LEVEL_HIGH>;
>+            power-domains = <&ps_avd_sys>;
>+            resets = <&ps_avd_sys>;
>+            iommus = <&avd_dart 0>;
>+        };
>+    };
>diff --git a/MAINTAINERS b/MAINTAINERS
>index 4cc4a2dc6d30..3c7c5fe3f0bc 100644
>--- a/MAINTAINERS
>+++ b/MAINTAINERS
>@@ -2643,6 +2643,7 @@ F:	Documentation/devicetree/bindings/iommu/apple,dart.yaml
> F:	Documentation/devicetree/bindings/iommu/apple,sart.yaml
> F:	Documentation/devicetree/bindings/leds/backlight/apple,dwi-bl.yaml
> F:	Documentation/devicetree/bindings/mailbox/apple,mailbox.yaml
>+F:	Documentation/devicetree/bindings/media/apple,avd.yaml
> F:	Documentation/devicetree/bindings/mfd/apple,smc.yaml
> F:	Documentation/devicetree/bindings/net/bluetooth/brcm,bcm4377-bluetooth.yaml
> F:	Documentation/devicetree/bindings/nvme/apple,nvme-ans.yaml
>
>-- 
>2.55.0
>
>
>_______________________________________________
>Linux-rockchip mailing list
>Linux-rockchip@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-rockchip