From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1032462AbdAEGFp (ORCPT ); Thu, 5 Jan 2017 01:05:45 -0500 Received: from mail-pg0-f51.google.com ([74.125.83.51]:35981 "EHLO mail-pg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1032428AbdAEGFO (ORCPT ); Thu, 5 Jan 2017 01:05:14 -0500 Subject: Re: [PATCH v6 03/14] ACPI: ARM64: IORT: add missing comment for iort_dev_find_its_id() To: Lorenzo Pieralisi References: <1483363905-2806-1-git-send-email-hanjun.guo@linaro.org> <1483363905-2806-4-git-send-email-hanjun.guo@linaro.org> <20170104143442.GA8604@red-moon> Cc: Marc Zyngier , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, Thomas Gleixner , Greg KH , Tomasz Nowicki , Ma Jun , Kefeng Wang , Agustin Vega-Frias , Sinan Kaya , charles.garcia-tobin@arm.com, huxinwei@huawei.com, yimin@huawei.com, Jon Masters From: Hanjun Guo Message-ID: <4915fe90-ea61-45b5-491d-0628456abed2@linaro.org> Date: Thu, 5 Jan 2017 14:05:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170104143442.GA8604@red-moon> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/1/4 22:34, Lorenzo Pieralisi wrote: > On Mon, Jan 02, 2017 at 09:31:34PM +0800, Hanjun Guo wrote: >> We are missing req_id's comment for iort_dev_find_its_id(), >> add it back. > > "Add missing req_id parameter to the iort_dev_find_its_id() function > kernel-doc comment." > >> Signed-off-by: Hanjun Guo >> Tested-by: Majun >> Tested-by: Xinwei Kong >> Cc: Lorenzo Pieralisi >> Cc: Tomasz Nowicki >> --- >> drivers/acpi/arm64/iort.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c >> index 46e2d82..174e983 100644 >> --- a/drivers/acpi/arm64/iort.c >> +++ b/drivers/acpi/arm64/iort.c >> @@ -446,6 +446,7 @@ u32 iort_msi_map_rid(struct device *dev, u32 req_id) >> /** >> * iort_dev_find_its_id() - Find the ITS identifier for a device >> * @dev: The device. >> + * @req_id: Device's Requster ID > > s/Requster/Requester > > We can send it upstream independently along with some other patches > in this series but I will have a look at the whole series first. Do you mean go to 4.10-rcx? Thanks Hanjun