From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4103C433EF for ; Thu, 21 Jul 2022 07:05:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232312AbiGUHF6 (ORCPT ); Thu, 21 Jul 2022 03:05:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229648AbiGUHF4 (ORCPT ); Thu, 21 Jul 2022 03:05:56 -0400 X-Greylist: delayed 1187 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 21 Jul 2022 00:05:55 PDT Received: from 2.mo561.mail-out.ovh.net (2.mo561.mail-out.ovh.net [46.105.75.36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3E0A7757D for ; Thu, 21 Jul 2022 00:05:55 -0700 (PDT) Received: from player697.ha.ovh.net (unknown [10.108.4.8]) by mo561.mail-out.ovh.net (Postfix) with ESMTP id 45C2C217BF for ; Thu, 21 Jul 2022 06:46:06 +0000 (UTC) Received: from RCM-web2.webmail.mail.ovh.net (ip-194-187-74-233.konfederacka.maverick.com.pl [194.187.74.233]) (Authenticated sender: rafal@milecki.pl) by player697.ha.ovh.net (Postfix) with ESMTPSA id 0069A2CD2E7F8; Thu, 21 Jul 2022 06:45:54 +0000 (UTC) MIME-Version: 1.0 Date: Thu, 21 Jul 2022 08:45:54 +0200 From: =?UTF-8?Q?Rafa=C5=82_Mi=C5=82ecki?= To: William Zhang Cc: Linux ARM List , joel.peshkin@broadcom.com, dan.beygelman@broadcom.com, Rob Herring , Krzysztof Kozlowski , Anand Gore , Kursad Oney , Florian Fainelli , Broadcom internal kernel review list , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND PATCH 5/9] arm64: dts: Add BCM4908 generic board dts In-Reply-To: <20220721000731.29597-1-william.zhang@broadcom.com> References: <20220721000731.29597-1-william.zhang@broadcom.com> User-Agent: Roundcube Webmail/1.4.13 Message-ID: <4919ef26ece22db845de584e3d9b3814@milecki.pl> X-Sender: rafal@milecki.pl X-Originating-IP: 194.187.74.233 X-Webmail-UserID: rafal@milecki.pl Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-Ovh-Tracer-Id: 17739115984414288859 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvfedrudelkedgudehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepggffhffvvefujghffgfkgihitgfgsehtjehjtddtredvnecuhfhrohhmpeftrghfrghlpgfoihhlvggtkhhiuceorhgrfhgrlhesmhhilhgvtghkihdrphhlqeenucggtffrrghtthgvrhhnpeegvdffjeelvdeggeetheegveejieetgeeiiefggeelveejffehieekhfduueelhfenucfkpheptddrtddrtddrtddpudelgedrudekjedrjeegrddvfeefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpohhuthdphhgvlhhopehplhgrhigvrheileejrdhhrgdrohhvhhdrnhgvthdpihhnvghtpedtrddtrddtrddtpdhmrghilhhfrhhomheprhgrfhgrlhesmhhilhgvtghkihdrphhlpdhnsggprhgtphhtthhopedupdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrkhgvrhhnvghlrdhorhhgpdfovfetjfhoshhtpehmohehiedu Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-07-21 02:07, William Zhang wrote: > Add generic bcm94908.dts file. > > Signed-off-by: William Zhang > --- > > arch/arm64/boot/dts/broadcom/bcmbca/Makefile | 1 + > .../boot/dts/broadcom/bcmbca/bcm94908.dts | 30 +++++++++++++++++++ > 2 files changed, 31 insertions(+) > create mode 100644 arch/arm64/boot/dts/broadcom/bcmbca/bcm94908.dts > > diff --git a/arch/arm64/boot/dts/broadcom/bcmbca/Makefile > b/arch/arm64/boot/dts/broadcom/bcmbca/Makefile > index d30fa75f0611..27741b71ba9e 100644 > --- a/arch/arm64/boot/dts/broadcom/bcmbca/Makefile > +++ b/arch/arm64/boot/dts/broadcom/bcmbca/Makefile > @@ -4,6 +4,7 @@ dtb-$(CONFIG_ARCH_BCMBCA) += \ > bcm4906-tplink-archer-c2300-v1.dtb \ > bcm4908-asus-gt-ac5300.dtb \ > bcm4908-netgear-raxe500.dtb \ > + bcm94908.dtb \ > bcm4912-asus-gt-ax6000.dtb \ > bcm94912.dtb \ > bcm963158.dtb \ AFAIU bcm94908 is a reference board name. I think I see some inconsistency in naming Broadcom's reference boards DTS files. If you take a look at in-kernel DTS files: find ./arch/arm*/boot/dts/ -name "*.dts" 99% of them are prefixed with family/SoC name. I did the same for bcm4908 (and Northstar) boards. So it's --.dts e.g. bcm4908-asus-gt-ac5300.dts To match that I *think* you should actually call your file: bcm4908-bcm94908 (or bcm4908-94908 depending on actual board name) First of all: am I correct here? Secondly: could you do that? I know many DTS files named ignoring SoC/ family prefix. Still maybe we could change it as some (this) point?