From: Tejun Heo <htejun@gmail.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Hugh Dickins <hugh@veritas.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
jens.axboe@oracle.com
Subject: Re: [PATCH] Fix kunmap() argument in sg_miter_stop
Date: Sun, 16 Nov 2008 14:16:51 +0900 [thread overview]
Message-ID: <491FACC3.1050202@gmail.com> (raw)
In-Reply-To: <20081115123916.0d83a89e@infradead.org>
Arjan van de Ven wrote:
> From 979d181d6199f639ba78c5eadf85857f6a9f3f89 Mon Sep 17 00:00:00 2001
> From: Arjan van de Ven <arjan@linux.intel.com>
> Date: Sat, 15 Nov 2008 11:23:58 -0800
> Subject: [PATCH] Fix kunmap() argument in sg_miter_stop
>
> kunmap() takes as argument the struct page that orginally got kmap()'d,
> however the sg_miter_stop() function passed it the kernel virtual address
> instead, resulting in weird stuff.
>
> Somehow I ended up fixing this bug by accident while looking for a bug
> in the same area.
>
> Reported-by: kerneloops.org
> CC: htejun@gmail.com
>
> Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
Argh... talk about confusing interfaces. Thanks a lot.
Acked-by: Tejun Heo <tj@kernel.org>
--
tejun
next prev parent reply other threads:[~2008-11-16 5:16 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-15 19:27 Arjan van de Ven
2008-11-15 20:15 ` Hugh Dickins
2008-11-15 20:27 ` Arjan van de Ven
2008-11-15 20:39 ` Arjan van de Ven
2008-11-16 5:16 ` Tejun Heo [this message]
2008-11-17 8:11 ` Jens Axboe
2008-11-17 8:22 ` Ingo Molnar
2008-11-17 8:30 ` Jens Axboe
2008-11-17 8:50 ` Ingo Molnar
2008-11-17 8:58 ` Jens Axboe
2008-11-17 9:34 ` Jens Axboe
2008-11-17 9:41 ` Ingo Molnar
2008-11-17 9:45 ` Jens Axboe
2008-11-17 11:13 ` Jens Axboe
2008-11-17 17:08 ` Jeremy Fitzhardinge
2008-11-17 17:10 ` Ingo Molnar
2008-11-17 17:15 ` Jeremy Fitzhardinge
2008-11-17 17:25 ` Linus Torvalds
2008-11-17 17:35 ` Jeremy Fitzhardinge
2008-11-17 18:14 ` [PATCH] xen: fix scrub_page() Ingo Molnar
2008-11-17 18:07 ` [PATCH] Fix kunmap() argument in sg_miter_stop Jens Axboe
2008-11-17 18:16 ` Linus Torvalds
2008-11-17 18:26 ` Jens Axboe
2008-11-18 8:27 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=491FACC3.1050202@gmail.com \
--to=htejun@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=hugh@veritas.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome