mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Denis Benato <denis.benato@linux.dev>
Cc: LKML <linux-kernel@vger.kernel.org>,
	platform-driver-x86@vger.kernel.org,
	 Hans de Goede <hansg@kernel.org>,
	"Luke D . Jones" <luke@ljones.dev>,
	 Mateusz Schyboll <dragonn@op.pl>,
	Denis Benato <benato.denis96@gmail.com>
Subject: Re: [PATCH] platform/x86: asus-armoury: add support for GU605CR
Date: Mon, 29 Dec 2025 15:09:11 +0200 (EET)	[thread overview]
Message-ID: <491d2182-930c-46fd-20f6-5d6e7f5ffeb7@linux.intel.com> (raw)
In-Reply-To: <20251225023841.1970513-1-denis.benato@linux.dev>

On Thu, 25 Dec 2025, Denis Benato wrote:

> Add TDP data for laptop model GU605CR.
> 
> Signed-off-by: Denis Benato <denis.benato@linux.dev>

Hi Denis,

I've applied these 4 to the review-ilpo-fixes branch, but next time please 
please make them a series instead of sending 4 very similar ID addition 
changes to the same file independently.

A series is easier for me to apply as a whole than 4 patches individually. 
Also, series won't cause some messy misapplication as easily as individual 
patches that can be applied in order different from what was used by the 
submitter to create them (it seems there were no context conflicts with 
these but I had to check that == extra work for me).

-- 
 i.

> ---
>  drivers/platform/x86/asus-armoury.h | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/drivers/platform/x86/asus-armoury.h b/drivers/platform/x86/asus-armoury.h
> index a1bb2005c3f3..d8814165d480 100644
> --- a/drivers/platform/x86/asus-armoury.h
> +++ b/drivers/platform/x86/asus-armoury.h
> @@ -950,6 +950,35 @@ static const struct dmi_system_id power_limits[] = {
>  			},
>  		},
>  	},
> +	{
> +		.matches = {
> +			DMI_MATCH(DMI_BOARD_NAME, "GU605CR"),
> +		},
> +		.driver_data = &(struct power_data) {
> +			.ac_data = &(struct power_limits) {
> +				.ppt_pl1_spl_min = 30,
> +				.ppt_pl1_spl_max = 85,
> +				.ppt_pl2_sppt_min = 38,
> +				.ppt_pl2_sppt_max = 110,
> +				.nv_dynamic_boost_min = 5,
> +				.nv_dynamic_boost_max = 20,
> +				.nv_temp_target_min = 75,
> +				.nv_temp_target_max = 87,
> +				.nv_tgp_min = 80,
> +				.nv_tgp_def = 90,
> +				.nv_tgp_max = 105,
> +			},
> +			.dc_data = &(struct power_limits) {
> +				.ppt_pl1_spl_min = 30,
> +				.ppt_pl1_spl_max = 85,
> +				.ppt_pl2_sppt_min = 38,
> +				.ppt_pl2_sppt_max = 110,
> +				.nv_temp_target_min = 75,
> +				.nv_temp_target_max = 87,
> +			},
> +			.requires_fan_curve = true,
> +		},
> +	},
>  	{
>  		.matches = {
>  			DMI_MATCH(DMI_BOARD_NAME, "GU605CW"),
> 

  reply	other threads:[~2025-12-29 13:09 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-25  2:38 Denis Benato
2025-12-29 13:09 ` Ilpo Järvinen [this message]
2025-12-29 14:56   ` Denis Benato

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=491d2182-930c-46fd-20f6-5d6e7f5ffeb7@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=benato.denis96@gmail.com \
    --cc=denis.benato@linux.dev \
    --cc=dragonn@op.pl \
    --cc=hansg@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®