mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ardb@kernel.org>
To: "Karl Mehltretter" <kmehltretter@gmail.com>
Cc: "Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
	"Heinrich Schuchardt" <xypron.glpk@gmx.de>,
	linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] efi/libstub: Fix efi_set_event_at() parameter documentation
Date: Thu, 10 Sep 2026 09:14:56 +0200	[thread overview]
Message-ID: <49225810-ec79-48b9-8d36-dff7296ef4d8@app.fastmail.com> (raw)
In-Reply-To: <20260910031853.15236-1-kmehltretter@gmail.com>



On Thu, 10 Sep 2026, at 05:18, Karl Mehltretter wrote:
> efi_set_event_at() documents ids although its array index argument is
> named idx. This produces missing and excess parameter warnings.
>
> Match the argument name and fix the adjacent spelling of array.
>
> Fixes: 8c0a839c2bcc ("efi/libstub: Descriptions for stub helper functions")
> Assisted-by: LLM
> Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
> ---
>  drivers/firmware/efi/libstub/efistub.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/firmware/efi/libstub/efistub.h 
> b/drivers/firmware/efi/libstub/efistub.h
> index fd91fc15ec81..049263a541ae 100644
> --- a/drivers/firmware/efi/libstub/efistub.h
> +++ b/drivers/firmware/efi/libstub/efistub.h
> @@ -224,8 +224,8 @@ typedef void (__efiapi 
> *efi_event_notify_t)(efi_event_t, void *);
>   * efi_set_event_at() - add event to events array
>   *
>   * @events:	array of UEFI events
> - * @ids:	index where to put the event in the array
> - * @event:	event to add to the aray
> + * @idx:	index where to put the event in the array
> + * @event:	event to add to the array
>   *
>   * boottime->wait_for_event() takes an array of events as input.
>   * Provide a helper to set it up correctly for mixed mode.
>

Queued up in efi/next - thanks.

      reply	other threads:[~2026-09-10  7:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-10  3:18 Karl Mehltretter
2026-09-10  7:14 ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49225810-ec79-48b9-8d36-dff7296ef4d8@app.fastmail.com \
    --to=ardb@kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=kmehltretter@gmail.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®