From: Marek Vasut <marex@nabladev.com>
To: Frank Li <Frank.li@oss.nxp.com>
Cc: linux-arm-kernel@lists.infradead.org,
Aswath Govindraju <a-govindraju@ti.com>,
Conor Dooley <conor+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>, Frank Li <Frank.Li@nxp.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Marc Kleine-Budde <mkl@pengutronix.de>,
Rob Herring <robh@kernel.org>,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/3] arm64: dts: imx95: Add support for Data Modul i.MX95 eDM SBC
Date: Tue, 29 Sep 2026 17:20:27 +0200 [thread overview]
Message-ID: <49303872-5622-4e1d-8e1a-01394ec29367@nabladev.com> (raw)
In-Reply-To: <arvPDq8sjjv7na01@SMW015318>
On 9/29/26 4:45 PM, Frank Li wrote:
Hello Frank,
>> + backlight_lvds: backlight-lvds {
>> + compatible = "pwm-backlight";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_panel_backlight_lvds>;
>> + brightness-levels = <0 1 10 20 30 40 50 60 70 75 80 90 100>;
>> + default-brightness-level = <7>;
>> + enable-gpios = <&gpio2 27 GPIO_ACTIVE_HIGH>;
>> + pwms = <&tpm3 3 5000000 0>;
>> + /* Disabled by default, unless display board plugged in. */
>> + status = "disabled";
>> + };
>
> The both backlight is not used in this dts, can you remove it and
> add these when it real use.
It's the same thing we do on the other boards, so I would prefer to keep
this consistent:
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts:
backlight: backlight {
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts:
compatible = "pwm-backlight";
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts-
brightness-levels = <0 1 10 20 30 40 50 60 70 75 80 90 100>;
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts-
default-brightness-level = <7>;
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts-
pwms = <&pwm1 0 5000000 0>;
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts-
/* Disabled by default, unless display board plugged in. */
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts-
status = "disabled";
arch/arm64/boot/dts/freescale/imx8mm-data-modul-edm-sbc.dts- };
prev parent reply other threads:[~2026-09-29 15:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 20:47 [PATCH v5 1/3] dt-bindings: phy: ti,tcan104x-can: Document Microchip ATA6563 Marek Vasut
2026-09-28 20:47 ` [PATCH v5 2/3] dt-bindings: arm: fsl: Document Data Modul i.MX95 eDM SBC Marek Vasut
2026-09-28 20:47 ` [PATCH v5 3/3] arm64: dts: imx95: Add support for " Marek Vasut
2026-09-29 14:45 ` Frank Li
2026-09-29 15:20 ` Marek Vasut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49303872-5622-4e1d-8e1a-01394ec29367@nabladev.com \
--to=marex@nabladev.com \
--cc=Frank.Li@nxp.com \
--cc=Frank.li@oss.nxp.com \
--cc=a-govindraju@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®