From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932235AbdJURIv (ORCPT <rfc822;w@1wt.eu>);
        Sat, 21 Oct 2017 13:08:51 -0400
Received: from mail-pf0-f194.google.com ([209.85.192.194]:57303 "EHLO
        mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932172AbdJURIt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 21 Oct 2017 13:08:49 -0400
X-Google-Smtp-Source: ABhQp+Suh+be5G1uu3elFS9R4/Obw/Tt0+CzMOwyybg7rA2okMCMgmy+8sneLoO8dQjTjf5YBvmv+Q==
Subject: Re: [PATCH v8 1/5] serdev: Make .remove in struct
 serdev_device_driver optional
To: Andrey Smirnov <andrew.smirnov@gmail.com>,
        linux-kernel@vger.kernel.org
Cc: linux-serial@vger.kernel.org, Rob Herring <robh@kernel.org>,
        cphealy@gmail.com, Lucas Stach <l.stach@pengutronix.de>,
        Nikita Yushchenko <nikita.yoush@cogentembedded.com>,
        Lee Jones <lee.jones@linaro.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Pavel Machek <pavel@ucw.cz>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Johan Hovold <johan@kernel.org>
References: <20171018170136.12347-1-andrew.smirnov@gmail.com>
 <20171018170136.12347-2-andrew.smirnov@gmail.com>
From: Guenter Roeck <linux@roeck-us.net>
Message-ID: <493297bf-245b-10be-2659-e9fa9f424f5e@roeck-us.net>
Date: Sat, 21 Oct 2017 10:08:40 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171018170136.12347-2-andrew.smirnov@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 10/18/2017 10:01 AM, Andrey Smirnov wrote:
> Using devres infrastructure it is possible to wirte a serdev driver

s/wirte/write/

otherwise

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> that doesn't have any code that needs to be called as a part of
> .remove. Add code to make .remove optional.
> 
> Cc: linux-kernel@vger.kernel.org
> Cc: linux-serial@vger.kernel.org
> Cc: Rob Herring <robh@kernel.org>
> Cc: cphealy@gmail.com
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Lucas Stach <l.stach@pengutronix.de>
> Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
> Cc: Johan Hovold <johan@kernel.org>
> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> ---
>   drivers/tty/serdev/core.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
> index c68fb3a8ea1c..f500f6a2ca88 100644
> --- a/drivers/tty/serdev/core.c
> +++ b/drivers/tty/serdev/core.c
> @@ -252,8 +252,8 @@ static int serdev_drv_probe(struct device *dev)
>   static int serdev_drv_remove(struct device *dev)
>   {
>   	const struct serdev_device_driver *sdrv = to_serdev_device_driver(dev->driver);
> -
> -	sdrv->remove(to_serdev_device(dev));
> +	if (sdrv->remove)
> +		sdrv->remove(to_serdev_device(dev));
>   	return 0;
>   }
>   
>