From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751835AbbJWNMy (ORCPT ); Fri, 23 Oct 2015 09:12:54 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:49749 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750892AbbJWNMw (ORCPT ); Fri, 23 Oct 2015 09:12:52 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Eric Auger , eric.auger@st.com, alex.williamson@redhat.com, b.reynal@virtualopensystems.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, christoffer.dall@linaro.org, patches@linaro.org Subject: Re: [PATCH v3 6/7] vfio: platform: use list of registered reset function Date: Fri, 23 Oct 2015 15:12:16 +0200 Message-ID: <4934120.DeNtNjTIFs@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1445603835-14506-7-git-send-email-eric.auger@linaro.org> References: <1445603835-14506-1-git-send-email-eric.auger@linaro.org> <1445603835-14506-7-git-send-email-eric.auger@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:7sgL1tOwA+kRmItnWzHeO/XbgPOx0ZHKVErXHiDnu/sAndwEFp+ zgr8yqnML36Pp6ibWWMuOnV8FTQGO6ffguhobY5alsBQVWvD5jsBw1DUJ06hGe0CJaVHmmJ jj1R7DXd3MBcVYUg9szW0SFelxR3jFvP2Z6T4OUlBb8dncDNKiZafffYeQlr3MgnlA9pQxw q0gsWFObP6DLuGE8zFF/w== X-UI-Out-Filterresults: notjunk:1;V01:K0:/dtSN0OnzQo=:IQklccwPlcEtARv4FXq7eF G7fEWiHjSyA5m1bld8dRSuuZuV2ZOpsT/vgsvaZyF7kayOG44ogX2qAbbnelkAkZQF15Zm4T2 f7p4p8y/E0hRhvdF3Vkp7y+GceNbYns6eC5Zl/JQjeIschcsaLHOQFRf1hpXkIcoOC73BXQSa 7Af6RCfuMH18bIueE2GsTVmCrsc/XvoKn1d71k4zS5l6aJKXFlKN+OEqMuuO8cGW7JY++ys/f Vuezjw1MHMD76NkAfyowCtc4NWckblhGAoozXb7I2nQQALOYfNZsI+h1chV05Hom8XTkmdHpC G8zM8l2HGNdoADNIzhRn8bB4fgZ9V2gCZMlWlcttrlmNg/MCr7OQZ1e8fSeauYN3rmQHVAN5Q P+vfBXlFzmKf2ZjyVshAk+wIW3+GbyZ4eIE1FIYdKJiKiDnbB5558L4pKMzocLp+ZoEhqy8f9 OzBIs0QnUPjBVNloXXlywfvsT0Brzan5thwmT+fcoCz2FL3bA9ZuS6JdnIrxsFxs+nfr8vCTg NpiBhilixfZNlTQnG9NmjWJUUlL9/xIysik/dB5wXYnb96EWg+bmMaU9uPVNb4F20Qs2zg3Wg LeDCp4MzBBvxyjAkqleEv2e/23O9G8qF+08U+6pQLgmeTTAydJJE9R1Qiexb5Tcu70VFBKrPh 7yoAEbLCw9LuLPjDvPAAvy3feuwzqcV6RurM/3STs990vSXe1Dedgjn+jKpm6ftJ6GvQ/0Hhz W/NRH71urYPhjh0N Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 23 October 2015 14:37:14 Eric Auger wrote: > Remove the static lookup table and use the dynamic list of registered > reset functions instead. Also load the reset module through its alias. > The reset struct module pointer is stored in vfio_platform_device. > > We also remove the useless struct device pointer parameter in > vfio_platform_get_reset. > > This patch fixes the issue related to the usage of __symbol_get, which > besides from being moot, prevented compilation with CONFIG_MODULES > disabled. > > Also usage of MODULE_ALIAS makes possible to add a new reset module > without needing to update the framework. This was suggested by Arnd. > > Signed-off-by: Eric Auger > Reported-by: Arnd Bergmann > > Reviewed-by: Arnd Bergmann but doesn't this need to come before patch 4/7? Arnd