From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: adau1761: Mark expected switch fall-though
Date: Thu, 9 Aug 2018 13:19:11 +0200 [thread overview]
Message-ID: <4934d9ae-96df-288b-2a7c-76aaa89246fe@metafoo.de> (raw)
In-Reply-To: <20180809093100.GC6132@sirena.org.uk>
On 08/09/2018 11:31 AM, Mark Brown wrote:
> On Wed, Aug 08, 2018 at 02:22:13PM -0500, Gustavo A. R. Silva wrote:
>
>> @@ -518,7 +518,8 @@ static int adau1761_setup_digmic_jackdetect(struct snd_soc_component *component)
>> ARRAY_SIZE(adau1761_jack_detect_controls));
>> if (ret)
>> return ret;
>> - case ADAU1761_DIGMIC_JACKDET_PIN_MODE_NONE: /* fallthrough */
>> + /* fall through */
>> + case ADAU1761_DIGMIC_JACKDET_PIN_MODE_NONE:
>> ret = snd_soc_dapm_add_routes(dapm, adau1761_no_dmic_routes,
>> ARRAY_SIZE(adau1761_no_dmic_routes));
>> if (ret)
>
> Again, are you *sure* here?
Well, it says so in the comment next to it :)
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
prev parent reply other threads:[~2018-08-09 11:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 19:22 Gustavo A. R. Silva
2018-08-09 9:31 ` Mark Brown
2018-08-09 11:19 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4934d9ae-96df-288b-2a7c-76aaa89246fe@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gustavo@embeddedor.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®