From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S965443AbdADH4Y (ORCPT <rfc822;w@1wt.eu>);
        Wed, 4 Jan 2017 02:56:24 -0500
Received: from mail-pf0-f174.google.com ([209.85.192.174]:36753 "EHLO
        mail-pf0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S965281AbdADH4V (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Jan 2017 02:56:21 -0500
Subject: Re: [PATCH v6 01/14] ACPI: ARM64: IORT: minor cleanup for
 iort_match_node_callback()
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
References: <1483363905-2806-1-git-send-email-hanjun.guo@linaro.org>
 <1483363905-2806-2-git-send-email-hanjun.guo@linaro.org>
 <20170103140839.GC7478@red-moon>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>, linux-acpi@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linuxarm@huawei.com, Thomas Gleixner <tglx@linutronix.de>,
        Greg KH <gregkh@linuxfoundation.org>, Tomasz Nowicki <tn@semihalf.com>,
        Ma Jun <majun258@huawei.com>, Kefeng Wang <wangkefeng.wang@huawei.com>,
        Agustin Vega-Frias <agustinv@codeaurora.org>,
        Sinan Kaya <okaya@codeaurora.org>, charles.garcia-tobin@arm.com,
        huxinwei@huawei.com, yimin@huawei.com, Jon Masters <jcm@redhat.com>
From: Hanjun Guo <hanjun.guo@linaro.org>
Message-ID: <49365234-2f2f-1607-e520-b98b61e1b5e9@linaro.org>
Date: Wed, 4 Jan 2017 15:56:15 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <20170103140839.GC7478@red-moon>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Lorenzo,

On 2017/1/3 22:08, Lorenzo Pieralisi wrote:
> On Mon, Jan 02, 2017 at 09:31:32PM +0800, Hanjun Guo wrote:
>> Cleanup iort_match_node_callback() a little bit to reduce
>> some lines of code, aslo fix the indentation in iort_scan_node().
>
> s/aslo/also
>
> "Also" in a commit log is a sign a patch should be split and that's what
> you should do even though I know it is tempting to merge all trivial
> changes into one single patch.
>
> Make it two patches please.

Will do, thanks!

Do you have more comments regarding this patch set? I will
incorporate all the comments and send out a new version.

Thanks
Hanjun