From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68CC438F22A for ; Fri, 6 Mar 2026 14:05:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772805954; cv=none; b=Nx1Bq04MNZHwdL5DwLtneZ1WWeYFVMkkKpYtTCArYVN+5NAGPkhLnAYlUq2JZuAkxWvRjqnuLOFOgP5BzE7UZaEKaEtVEsbur/cH8okbOCQaFQlsFN1Mq0XCEQcjjkmTmpElT8tID7evqNUr/gIK2qawkM7pWc8W76qk1R1FFig= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772805954; c=relaxed/simple; bh=PoeET+qFa6pR0XKfw5tKjEtxRNaloT7k8RrQJIDBWjY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IScoOL8mlZ/L8e/Wb9BvG0q9nd668q0CeBTweMQf3O38RLNSaTLClf3Cp/JmiyLwUOGqJVRuKdT33NMVTN6hUtslK+ZwadFGvA7hh5mnqwwiI0ExY1UGxGaFns71yNjMRq3DM1iAYnNXjtAugCS9GKr2LIasqvozCP6CmWXC+8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=WYg3ajWx; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ebZ4qqtM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="WYg3ajWx"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ebZ4qqtM" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 626BajD34186027 for ; Fri, 6 Mar 2026 14:05:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= U+VfUnExQBW7y3BidnhCqBz/4vBGXnsLYPZTfRBzDOc=; b=WYg3ajWxYC5Ou+vJ 3t8tJd7Ts4aC24Xe//pdxy9F7B4kBIWetbNTPWll5QHD5jOgjO4OiLQKG8p7GH/8 wz6Rjzs6x1zFcfAC7/YQBBMqqkG+ObKI2ik/hdpgtKo10hQ0W4+WzWfL85KRcfWI TuFa9Tv3HaWg0hsa7VODN22E8sYSuNsDBf7LILC7XrQssESF6einmdYB1XdYx6FI VrF8fHo8bpadiGDnquzI9WU9l+Dm6sM+wobyfZ72Jk0vlz4fUMpMQltcF94LHg6k IabH//dkv53UNmrZcjvhdwND4RDNUWJbsMD53EL9cDT9J5M3hgmdxruPT/WkF2ZW ss8DIg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cqruk9kw0-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 06 Mar 2026 14:05:51 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ae59e057f1so63208725ad.1 for ; Fri, 06 Mar 2026 06:05:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772805950; x=1773410750; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=U+VfUnExQBW7y3BidnhCqBz/4vBGXnsLYPZTfRBzDOc=; b=ebZ4qqtMKC+YRNgbvli3ajUC5lx0n0uTkrUJi8NxXzVYza7vyZvJl5DOjoLo43RzVG NggUfHygWfd4An5QqN9kyhHD0i9uof7VvITH/20j0+VXR8CW18KqZ4uTQjQ3PT2ffEwi QJVJaaPcWbLlB53zGHdjyCOIzHJ68iVdtC/XgBafe2aE44SKHTYJzNz7V+n6jIjXAnar 5B099Ci22pWeL0rmgzJO74n7SrRySqH537Vd1kW+LvUjbYe86W9MYvXAuTGn9DnmGD/3 MHOKQTrRevqC68AhMpAo8KgSphocd0A6kfjcUwvNZhKfgE1ffRjbbSRgbEqEEQw6G4YC ioog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772805950; x=1773410750; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=U+VfUnExQBW7y3BidnhCqBz/4vBGXnsLYPZTfRBzDOc=; b=F0HJW1bFKMhhdrCCWjTCRisJeatkt/PsltO3rcvHBb5OB7o4rEASi23GCkVt6k44UN nNyxwCg4UAO/YHlWEHdP42FaHOzjIvoh2xOlB6Aa7goRdu/P/amnOiWOqpPJIfajR0rt k9mmOs3v+xHU5KgqrJRJN60WGLI8BQlGVI0AdIwIhs/elQvMWiO7Yz+9DUQY8CgFI4nK TYxcrrIwyi6ZHRO81dRpYvAZIcJSqdwt35f2mI9QoFmHxAUeBQlljGyiT4O68CJ3YRQ7 b0lHJiTBCxgowxJVvugk6qss/YSyVIii7RWr4xbpDm+V5+zDL8N/ZsXEfOQ0jhJQ+SaI 8Zng== X-Forwarded-Encrypted: i=1; AJvYcCXsmpa6cstdRXxXBB9C4upWeCyQXHuPzWlpaKCZbMqbCp9urEwrYQzB+EnDgi4r+WAKTczsxV+fXTUG2uk=@vger.kernel.org X-Gm-Message-State: AOJu0Yxh2pajc57i15f4slfKdEwBuvo7UbqVZ6r0OtbmY42RqLz1Qx8w MM6B6YhlZWmTOOoPStnpIOloaF5Mhi587Dzmi6AcwxwmHdRUHa9uiVZyzMUikcBI73CwRZ0iuGj G3KmWEZs9bSitk917MgBFr4SJuxGfUgYCZ4UDMwxhtI52kga1ceRytQEyQIwqs28rL+E= X-Gm-Gg: ATEYQzwfDL5bOxAX7CQsKhvjs0VpLFK3Jl04vtrPk47rXNFrdUQJdtMJ8tZQLYpUdQG 5ysbaoXb8KfRr3xZI8fJ+Dqj5zVyvUb5lE5Woabyp9jx2cKOJKvem2gRmC9+ZLPB+Iwr3N+h/oO +MMU/lmMJ3uMrqHzVBiPpsGTCtjTYvPrTfiJPTreuvZQfszN4wI8qrW2Plp15HP8h/CDBODFe8D qlUqLEHbKnCXq92KDyiH49hLxrvirIen82dDoH5/wE6qQhBrkDy2Bz4OcxoNuHTMDk88R3AQL22 eTglBITHkSzA4kvDuLfnLMo/uy9Ke3nNpEZiu1iOYQMRCU38ePZlpvpQO5OJmJl7v5h2JJuWtF3 7sWT8T21RDi2DT9VtbJ3dvaIn6M2H7kAkxVFgGSIxlsRY2r4dzkfSBL6oX5/tp8IyKAdPJVDNAS ghqEdtsFZOrJs= X-Received: by 2002:a17:902:cccf:b0:2ae:805d:e0b5 with SMTP id d9443c01a7336-2ae824bbaafmr22917505ad.56.1772805950079; Fri, 06 Mar 2026 06:05:50 -0800 (PST) X-Received: by 2002:a17:902:cccf:b0:2ae:805d:e0b5 with SMTP id d9443c01a7336-2ae824bbaafmr22917145ad.56.1772805949445; Fri, 06 Mar 2026 06:05:49 -0800 (PST) Received: from [10.133.33.226] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae83f7864dsm22663795ad.49.2026.03.06.06.05.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Mar 2026 06:05:49 -0800 (PST) Message-ID: <493da66e-3c3c-40af-8859-646c144acbdb@oss.qualcomm.com> Date: Fri, 6 Mar 2026 22:05:45 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 10/11] scsi: ufs: ufs-qcom: Implement vops apply_tx_eqtr_settings() To: Manivannan Sadhasivam Cc: avri.altman@wdc.com, bvanassche@acm.org, beanhuo@micron.com, martin.petersen@oracle.com, linux-scsi@vger.kernel.org, "James E.J. Bottomley" , "open list:ARM/QUALCOMM MAILING LIST" , open list References: <20260304135313.413688-1-can.guo@oss.qualcomm.com> <20260304135313.413688-11-can.guo@oss.qualcomm.com> Content-Language: en-US From: Can Guo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA2MDEzNSBTYWx0ZWRfX3geUDE4GVCuA aVA3ficG93AeHLPYkAie8cWZzawUdv8Pe0elg8zXfBSt0t7OGCj7l3sURxzn8Qu11ydhBIvoRs1 qbMnBv8axODtQGNvC4SMN1t0BuEdSjpJpxqPhhZPw2ulq0qhRgBk/kNjSgLTC1fMGo8UL7vOMy4 U8HRPs1F3wsYLoPB3rMbPse/0fKY8Xl5MvWwSLlQ9or4Q2TyhKYoUoUvuIZ5ijhAghdI8x3r3PP MBv0HE/wDFapiLhcdbtrmydhxEFlbRdSyf7o4I5f7v2pkGyL+Tenr5rB2MNlPwLB5w6N2ufrORx hGM/xTcAcsnewnrciEcBjEnL/EQInEV1dTmRu9WRb8WULUtwR4Gay//v44yZK+ijcpIc7NMKKQg bs0oTsj06VFtW0jwesGsJkY5eLHPlfWZdeK/SWB6ouB3q+uVwAcwl3+zL+4a3NvmWIKKKGJEsna SWXUZvHH+UW7B64Xl+Q== X-Proofpoint-ORIG-GUID: konk9K8l32KrZY0YamMSpK1xBn81IM55 X-Authority-Analysis: v=2.4 cv=DvZbOW/+ c=1 sm=1 tr=0 ts=69aadf3f cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=cWpPSTlTcvdTqOXPF7sA:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: konk9K8l32KrZY0YamMSpK1xBn81IM55 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-06_04,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 bulkscore=0 adultscore=0 suspectscore=0 clxscore=1015 phishscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603060135 On 3/4/2026 11:41 PM, Manivannan Sadhasivam wrote: > On Wed, Mar 04, 2026 at 05:53:12AM -0800, Can Guo wrote: >> On some platforms, when Host Software triggers TX Equalization Training, >> HW does not take TX EQTR settings programmed in PA_TxEQTRSetting, instead >> HW takes TX EQTR settings from PA_TxEQG1Setting. Implement vops >> apply_tx_eqtr_setting() to work around it by programming TX EQTR settings >> to PA_TxEQG1Setting during TX EQTR procedure. >> >> Signed-off-by: Can Guo >> --- >> drivers/ufs/host/ufs-qcom.c | 33 +++++++++++++++++++++++++++++++++ >> drivers/ufs/host/ufs-qcom.h | 2 ++ >> 2 files changed, 35 insertions(+) >> >> diff --git a/drivers/ufs/host/ufs-qcom.c b/drivers/ufs/host/ufs-qcom.c >> index b8fa4670ddd6..89bea823a08b 100644 >> --- a/drivers/ufs/host/ufs-qcom.c >> +++ b/drivers/ufs/host/ufs-qcom.c >> @@ -2848,6 +2848,28 @@ static int ufs_qcom_get_rx_fom(struct ufs_hba *hba, >> return ret; >> } >> >> +static int ufs_qcom_apply_tx_eqtr_settings(struct ufs_hba *hba, >> + struct ufs_pa_layer_attr *pwr_mode, >> + struct tx_eqtr_iter *h_iter, >> + struct tx_eqtr_iter *d_iter) >> +{ >> + struct ufs_qcom_host *host = ufshcd_get_variant(hba); >> + u32 setting = 0; >> + int lane, ret; >> + >> + if (host->hw_ver.major != 0x7 || host->hw_ver.minor > 0x1) >> + return 0; >> + >> + for (lane = 0; lane < h_iter->num_lanes; lane++) { >> + setting |= TX_HS_PRESHOOT_BITS(lane, h_iter->preshoot); >> + setting |= TX_HS_DEEMPHASIS_BITS(lane, h_iter->deemphasis); >> + } >> + >> + ret = ufshcd_dme_set(hba, UIC_ARG_MIB(PA_TXEQG1SETTING), setting); > nit: return ... Sure Sir. Thanks. Can Guo. > > - Mani >