From: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
To: Kees Cook <keescook@chromium.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>
Cc: kernel test robot <lkp@intel.com>, Rich Felker <dalias@libc.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Nicolas Schier <n.schier@avm.de>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] sh: Fix build with CONFIG_UBSAN=y
Date: Wed, 31 Jan 2024 12:03:44 +0100 [thread overview]
Message-ID: <494586ed5a0871cf7cfd005f513577952306a0bc.camel@physik.fu-berlin.de> (raw)
In-Reply-To: <20240130232717.work.088-kees@kernel.org>
Hi Kees,
On Tue, 2024-01-30 at 15:27 -0800, Kees Cook wrote:
> The early boot stub for sh had UBSan instrumentation present where it is
> not supported. Disable it for this part of the build.
>
> sh4-linux-ld: arch/sh/boot/compressed/misc.o: in function `zlib_inflate_table':
> misc.c:(.text+0x670): undefined reference to `__ubsan_handle_shift_out_of_bounds'
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202401310416.s8HLiLnC-lkp@intel.com/
> Cc: Yoshinori Sato <ysato@users.sourceforge.jp>
> Cc: Rich Felker <dalias@libc.org>
> Cc: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: Nicolas Schier <n.schier@avm.de>
> Cc: linux-sh@vger.kernel.org
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> arch/sh/boot/compressed/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/sh/boot/compressed/Makefile b/arch/sh/boot/compressed/Makefile
> index b5e29f99c02c..6c6c791a1d06 100644
> --- a/arch/sh/boot/compressed/Makefile
> +++ b/arch/sh/boot/compressed/Makefile
> @@ -12,6 +12,7 @@ targets := vmlinux vmlinux.bin vmlinux.bin.gz vmlinux.bin.bz2 \
> vmlinux.bin.lzma vmlinux.bin.xz vmlinux.bin.lzo $(OBJECTS)
>
> GCOV_PROFILE := n
> +UBSAN_SANITIZE := n
>
> #
> # IMAGE_OFFSET is the load offset of the compression loader
Thanks for the patch. I'm looking into this now and will provide the review later.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer
`. `' Physicist
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
next prev parent reply other threads:[~2024-01-31 11:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 23:27 Kees Cook
2024-01-31 11:03 ` John Paul Adrian Glaubitz [this message]
2024-01-31 11:19 ` John Paul Adrian Glaubitz
2024-02-02 10:32 ` Kees Cook
2024-02-02 11:06 ` John Paul Adrian Glaubitz
2024-02-11 10:39 ` John Paul Adrian Glaubitz
2024-02-12 18:26 ` Kees Cook
2024-02-12 18:45 ` John Paul Adrian Glaubitz
2024-02-14 12:52 ` John Paul Adrian Glaubitz
2024-03-01 5:46 ` Liu, Yujie
2024-03-01 14:38 ` John Paul Adrian Glaubitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=494586ed5a0871cf7cfd005f513577952306a0bc.camel@physik.fu-berlin.de \
--to=glaubitz@physik.fu-berlin.de \
--cc=dalias@libc.org \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lkp@intel.com \
--cc=masahiroy@kernel.org \
--cc=n.schier@avm.de \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®