From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1757355AbcGJWJF (ORCPT <rfc822;w@1wt.eu>);
	Sun, 10 Jul 2016 18:09:05 -0400
Received: from mout.kundenserver.de ([212.227.126.135]:56913 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1757207AbcGJWJB (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 10 Jul 2016 18:09:01 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Wan Zongshun <vw@iommu.org>, Russell King <linux@armlinux.org.uk>,
        devicetree@vger.kernel.org, linux-clk@vger.kernel.org,
        jason@lakedaemon.net, Daniel Lezcano <daniel.lezcano@linaro.org>,
        linux-kernel@vger.kernel.org, p.zabel@pengutronix.de,
        Thomas Gleixner <tglx@linutronix.de>,
        Wan Zongshun <mcuos.com@gmail.com>
Subject: Re: [PATCH v2 01/10] ARM: NUC900: Add nuc970 machine support
Date: Mon, 11 Jul 2016 00:11:31 +0200
Message-ID: <4947302.8IpnGALVQ9@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-22-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1468135649-19980-2-git-send-email-vw@iommu.org>
References: <1468135649-19980-1-git-send-email-vw@iommu.org> <1468135649-19980-2-git-send-email-vw@iommu.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:JVO/BpxfriLe8pKDQ2ziTaPSjCoaEOyilhi/loYwmIKEyj4zmGe
 gp5SxCZnmsyD2n+nu07Gh76rQlxsXn+LQSTqHPn0kaMnM6X3TJEq9v39Hfn8TmS9T5ysVyN
 WrPH0vVaka9M7LF8pZOYvLApi0iVumcs6fVfv00jdsQ3Va6cx+VfcwsNsKOfJOgE/+ODRSu
 pL/uooqtRpITnLHYt8tQA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:TeORxWU7cLc=:TPPEPLqXDMJGBBXEwpKeIK
 gWG4V30Ehv78tbHeZkEFKwMTMWJ9g/hfNjROqImWZOu1QjNyNz1dY2Pi1pnXsl/5PIxAhU9k9
 2Bl5kXhCIyIBIgjt+wT21jNbltegKu7ZVgZFyDNuiS2zcsue4wDoRrtLVAXnzLErApNDCFUkr
 YjTEJf1EOnmKOLZ+B4Y9slNc++8WLTD5EFWPKMwBO/yILrpUjCwIwpqMrMs9GWm/RxPObtRfq
 2rR2Et/G/asUljJZpGIIIu5Y0ToUnzsVfEUgGiYOjsB+vzWCZEniqnk+EIx3KYLGYpkHI5pM/
 woP0O2m2cA5QWPbtuVX1f5RihdtINTpOBElz13N6sCItn3M5f0qAl+l8iLwpxJS4IaUdgValL
 u1Uce7ftIC3nw6Vew5wLTZ+f+rT+8MiN6/dJivJNLVJEfxrP4U/4OrYJgjWKjA6hTkbxvfVOT
 b+4ZXIz9Z6DoyYnm31W7aiUqyP3ZdGN0aHP7K58EvyvPqqHIkM5BgYLLV0gDn5s/YrjYU7ly1
 +GhP7/pw9NoaZazPggc7tBHWMFREBcv5oRiGPcVEF3DMeDP/Ujwabsnv9Fxvnmu8y41mQiKcH
 U2r3uZYmke/3R9BxQwaGgRT3tJGn2pLZZ7Jh4zlk7nK3buaGsk9kFHbYvIt3oFI5LF1qEAj3L
 Cj4PqxmHvER/83owZdZf3hgWLph9n9rUdLjuh4/N2/Z1z10+1U7XoV+vANEr/Ad20IWjbwK7B
 2I+y0dWIf28RqitT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sunday, July 10, 2016 3:27:21 PM CEST Wan Zongshun wrote:
> +
> +#include <linux/platform_device.h>
> +#include <linux/clk.h>
> +#include <linux/clkdev.h>
> +#include <linux/delay.h>
> +#include <linux/err.h>
> +#include <linux/gpio.h>
> +#include <linux/init.h>
> +#include <linux/reboot.h>
> +#include <linux/of_address.h>
> +#include <linux/of_platform.h>
> +#include <linux/sys_soc.h>
> +#include <linux/semaphore.h>
> +
> +#include <asm/system_misc.h>
> +#include <asm/mach/arch.h>
> +
> +static void __init nuc900_machine_init(void)
> +{
> +       of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
> +}


This is the default for .init_machine, so you can leave the function
undefined.

> +static const char *nuc900_dt_compat[] __initconst = {
> +       "nuvoton,nuc970",
> +       NULL,
> +};
> +
> +DT_MACHINE_START(nuc900_dt, "Nuvoton NUC900 (Device Tree Support)")
> +       .init_machine   = nuc900_machine_init,
> +       .dt_compat      = nuc900_dt_compat,
> +MACHINE_END
> 

After that, you can probably remove most of the #include statements.
The file is still needed for now, until you move to ARCH_MULTIPLATFORM,
at which point the entire machine descriptor is redundant.

	Arnd