mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hannes Eder <hannes@hanneseder.net>
To: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org
Subject: [PATCH 3/6] drm/i915: fix sparse warnings: move 'extern' decls to header file
Date: Thu, 18 Dec 2008 21:22:24 +0100	[thread overview]
Message-ID: <494ad5d9.0ab6660a.2341.ffff80b7@mx.google.com> (raw)

Move 'extern'-decls from "intel_dvo.c" to "dvo.h", as "dvo.h" is
included by and only by files where the symbols are either defined or
used.

Fix this sparse warnings:

  drivers/gpu/drm/i915/dvo_ch7xxx.c:358:26: warning: symbol 'ch7xxx_ops' was not declared. Should it be static?
  drivers/gpu/drm/i915/dvo_ch7017.c:444:26: warning: symbol 'ch7017_ops' was not declared. Should it be static?
  drivers/gpu/drm/i915/dvo_ivch.c:432:26: warning: symbol 'ivch_ops' was not declared. Should it be static?
  drivers/gpu/drm/i915/dvo_tfp410.c:325:26: warning: symbol 'tfp410_ops' was not declared. Should it be static?
  drivers/gpu/drm/i915/dvo_sil164.c:292:26: warning: symbol 'sil164_ops' was not declared. Should it be static?

Signed-off-by: Hannes Eder <hannes@hanneseder.net>
---
 drivers/gpu/drm/i915/dvo.h       |    6 ++++++
 drivers/gpu/drm/i915/intel_dvo.c |    6 ------
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/i915/dvo.h b/drivers/gpu/drm/i915/dvo.h
index e80866c..e747ac4 100644
--- a/drivers/gpu/drm/i915/dvo.h
+++ b/drivers/gpu/drm/i915/dvo.h
@@ -148,4 +148,10 @@ struct intel_dvo_dev_ops {
 	void (*dump_regs)(struct intel_dvo_device *dvo);
 };
 
+extern struct intel_dvo_dev_ops sil164_ops;
+extern struct intel_dvo_dev_ops ch7xxx_ops;
+extern struct intel_dvo_dev_ops ivch_ops;
+extern struct intel_dvo_dev_ops tfp410_ops;
+extern struct intel_dvo_dev_ops ch7017_ops;
+
 #endif /* _INTEL_DVO_H */
diff --git a/drivers/gpu/drm/i915/intel_dvo.c b/drivers/gpu/drm/i915/intel_dvo.c
index cc621c8..8b8d6e6 100644
--- a/drivers/gpu/drm/i915/intel_dvo.c
+++ b/drivers/gpu/drm/i915/intel_dvo.c
@@ -37,12 +37,6 @@
 #define CH7xxx_ADDR	0x76
 #define TFP410_ADDR	0x38
 
-extern struct intel_dvo_dev_ops sil164_ops;
-extern struct intel_dvo_dev_ops ch7xxx_ops;
-extern struct intel_dvo_dev_ops ivch_ops;
-extern struct intel_dvo_dev_ops tfp410_ops;
-extern struct intel_dvo_dev_ops ch7017_ops;
-
 static struct intel_dvo_device intel_dvo_devices[] = {
 	{
 		.type = INTEL_DVO_CHIP_TMDS,
-- 
1.5.6.3


                 reply	other threads:[~2008-12-18 23:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=494ad5d9.0ab6660a.2341.ffff80b7@mx.google.com \
    --to=hannes@hanneseder.net \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome