mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: Yeking@Red54.com, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Peter Robinson <pbrobinson@gmail.com>,
	Fabio Aiuto <fabioaiuto83@gmail.com>,
	linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: rtl8723bs: select CONFIG_CRYPTO_LIB_AES
Date: Mon, 24 Feb 2025 09:53:36 +0100	[thread overview]
Message-ID: <494bfb9c-0000-44fb-b33a-e42422488c95@redhat.com> (raw)
In-Reply-To: <tencent_0BDDF3A721708D16A2E7C3DAFF0FEC79A105@qq.com>

Hi,

On 22-Feb-25 8:36 PM, Yeking@Red54.com wrote:
> From: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>
> 
> This fixes the following issue:
> ERROR: modpost: "aes_expandkey" [drivers/staging/rtl8723bs/r8723bs.ko]
> undefined!
> ERROR: modpost: "aes_encrypt" [drivers/staging/rtl8723bs/r8723bs.ko]
> undefined!
> 
> Fixes: 7d40753d8820 ("staging: rtl8723bs: use in-kernel aes encryption in OMAC1 routines")
> Fixes: 3d3a170f6d80 ("staging: rtl8723bs: use in-kernel aes encryption")
> Signed-off-by: 谢致邦 (XIE Zhibang) <Yeking@Red54.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Regards,

Hans



> ---
>  drivers/staging/rtl8723bs/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/rtl8723bs/Kconfig b/drivers/staging/rtl8723bs/Kconfig
> index 8d48c61961a6..353e6ee2c145 100644
> --- a/drivers/staging/rtl8723bs/Kconfig
> +++ b/drivers/staging/rtl8723bs/Kconfig
> @@ -4,6 +4,7 @@ config RTL8723BS
>  	depends on WLAN && MMC && CFG80211
>  	depends on m
>  	select CRYPTO
> +	select CRYPTO_LIB_AES
>  	select CRYPTO_LIB_ARC4
>  	help
>  	This option enables support for RTL8723BS SDIO drivers, such as


      reply	other threads:[~2025-02-24  8:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-22 19:36 Yeking
2025-02-24  8:53 ` Hans de Goede [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=494bfb9c-0000-44fb-b33a-e42422488c95@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=Yeking@Red54.com \
    --cc=fabioaiuto83@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=pbrobinson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®