From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2352413245 for ; Thu, 5 Feb 2026 14:44:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770302665; cv=none; b=ZxyiURdXGIRYpBaX6PJKRrAl+AOb3FDLlkcQ5ozUkFg7R7O3LoFvmLrLL8dbfFXKCAUQBkL51Vq5ahcd+ng/Rw6Yige4j+yyEPgrOiDhLKSi3uIMNtCbpvluindiFa/aTsc/X6686hdZ0Lsnzdx0OO1DZNDOepbd7nWawthWXM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770302665; c=relaxed/simple; bh=PIqaVXNQ5avKJlj+GDHcP0gyG7eXBn59rD+0P/4iLvY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pCUgxXzuX0PhS/U4UprT0WtwB1PXDnkPpSufN0HsoPMizINwn62DqHjP8QGXwBvmGLcJD7qG/ORGz1mLbAjLjBZzJMwEa7f+y5/QFDJltJZ32LJZOSmnRnU8mT3pdJQ3SblErmiwZ6ny0ThrUhpMaGciObA1gk0bF0wgISjvFsY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=POHMtUfG; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Aa6tYdNk; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="POHMtUfG"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Aa6tYdNk" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770302664; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=31gdjaItHe4PG098cF4IzTnQcXvjAVhk0kFze4dcVRA=; b=POHMtUfGvD2cq+nZd/yMDYMsd7aWddReTirrHGcLp92SzAZGdDcTu6/+mstSg8Kh8/+RGn U0h8otQ+KvaCopcKoPMtgwamglvMPXU4/Qk+XlzG+vLIJPbPpD623Dyi/4AK9GStu48o4a zKc7GsWnoPQFGUaZJxin5zTPkSDhitw= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-111-MvdOdmW3O1i0_jJYqWjChg-1; Thu, 05 Feb 2026 09:44:23 -0500 X-MC-Unique: MvdOdmW3O1i0_jJYqWjChg-1 X-Mimecast-MFC-AGG-ID: MvdOdmW3O1i0_jJYqWjChg_1770302662 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-43624564fc9so499513f8f.2 for ; Thu, 05 Feb 2026 06:44:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770302662; x=1770907462; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=31gdjaItHe4PG098cF4IzTnQcXvjAVhk0kFze4dcVRA=; b=Aa6tYdNkcLi2hzY1rEPFEeB6WkQeQ+Hge/3fl2HTe9Ys/4LIpkYW/mIoKuPp1uZHQ0 UL5HLifz0IlaMHNlslaKY355HwY68cR1wmW+1f7+wMOPBZDtEBIyPFjhxuqMOLXTfNlc X+BmUQjwUsUcffjzyKZRj8Q2ANGTcRzQC51JyWDw+RHYx5H13xM3rw/aAAVqFGAG4SS6 YhTBGQtTFaOk/IIJns0bU4ue2CHbwmLKIja7SajbUaittyos+bGKdOxanWw5inRBq7RS N7KECfpcccqzKjWeXw4gPPxFZzdNbzfSv8SnBi/pEoDCJm/gT0AERKWvmFnZvbGBRoNw xhUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770302662; x=1770907462; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=31gdjaItHe4PG098cF4IzTnQcXvjAVhk0kFze4dcVRA=; b=U8KmQZNGpv06eSefkabeaBTW8xDIoYPGJ5HzaXUUW4lq1j3LE5KkNSzIj5Dyc+qujd SdMxxRUiI8sz2c1tbnGlg0oDWJ4ZUHb9GWoQBTeupQruCCvJfBtD1Zie2rc0mFGtvv6k kxK1rRg3O7ADqy4vT3Oy5r8RIjrrxbXRT6pbu9kpfYc8LDimyLWsEG31aVXFRHb3WzOm eIl/V1DfGA9oIBvd/HRCbqcHeijHpS0afIHjqa89PPHwfqzqXJz+Jg69b64qaZrW7yIs TqBdReMBWF9ResH08aCH59XjXO8jqBpJH/yqoBtXi0ubIAmVPmrNmHM0eXrimI4vmj6V BQEw== X-Forwarded-Encrypted: i=1; AJvYcCXwpeBwI12SKjmrRmWFuZTiboDRIJUDwJSWG+yiaq/P4NqwjfNQbPeafE4fzrfGRzrVY7DboN8g07SXsgE=@vger.kernel.org X-Gm-Message-State: AOJu0YyUcR4UBB674Ia6GOx+kt7j9mHq2ap2ySSgaMmMGMWr4r3YTktp eQZTiKuoxTrQd68x7SVQM+DOEp05o+yl6MI8aVIZFXs8VoK0G7CrUZqREa2U5B1vUYXFnPoB4MZ xpTHLsYrSeUxPuYCwAzseCK8yh+G7IqjnZJRSVebLw0sZSEvPmlUMnzQifCgq3oLLaA== X-Gm-Gg: AZuq6aJ/qhRst47tmvx1SmcoN/faNih6jh/o8r2rwbRr1WLqiRzU+MBBWWxuSOvplNR EK2hYEGBQKBYhzMn6nstENbGxwzweNhg/i8zEmqF7AsUomiI5KOo1wyZPmfntYafRWSNgtI9Rcl Y2Wb33NTqaRLv/Vn/0CaD9IDPMe8tbIOT12Ws8HsDmez9tSxzxxEiY9pT2qEM7mmrT7nQkqB5qB e9U66irdvscXu8qfOmr0yS1daDNjYFn56KeYmxnLshfyERyZVdmdf3YRgkRXDtBnRfN+XshbUdt G40/ZbI/lomYDhWvFViAfKYFHMyeSvdeR+/uDs7B1VZ+8cCYbU4iU5fWRTGtqygM1bAuaHkDIqj Mr9UAJc1oBSIN X-Received: by 2002:a05:6000:60f:b0:430:f255:14b3 with SMTP id ffacd0b85a97d-4361805cf28mr9267187f8f.43.1770302662105; Thu, 05 Feb 2026 06:44:22 -0800 (PST) X-Received: by 2002:a05:6000:60f:b0:430:f255:14b3 with SMTP id ffacd0b85a97d-4361805cf28mr9267141f8f.43.1770302661687; Thu, 05 Feb 2026 06:44:21 -0800 (PST) Received: from [192.168.88.32] ([216.128.11.114]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-436180647aasm13164858f8f.41.2026.02.05.06.44.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Feb 2026 06:44:21 -0800 (PST) Message-ID: <49573634-3837-4f35-908a-44ccdadca1f8@redhat.com> Date: Thu, 5 Feb 2026 15:44:19 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3] net: dsa: eliminate local type for tc policers To: David Yang , netdev@vger.kernel.org Cc: Vladimir Oltean , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , linux-kernel@vger.kernel.org References: <20260203172207.98533-1-mmyangfl@gmail.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260203172207.98533-1-mmyangfl@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 2/3/26 6:22 PM, David Yang wrote: > diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h > index 596ab9791e4d..a2b1b752958a 100644 > --- a/include/net/flow_offload.h > +++ b/include/net/flow_offload.h > @@ -275,7 +275,7 @@ struct flow_action_entry { > u32 trunc_size; > bool truncate; > } sample; > - struct { /* FLOW_ACTION_POLICE */ > + struct flow_action_police { /* FLOW_ACTION_POLICE */ > u32 burst; > u64 rate_bytes_ps; > u64 peakrate_bytes_ps; I find a bit unusual put the new type definition inside a wider struct. I think it would be better move the struct flow_action_police standalone. /P