Re: [PATCH] drm/v3d: Drop allocation of object without mountpoint

[Matthias Brugger <mbrugger@suse.com>]

Hi Maria,

On 29/10/2024 01:41, Maíra Canal wrote:
> Hi Matthias,
> 
> Thanks for your patch!
> 
> On 28/10/24 11:27, matthias.bgg@kernel.org wrote:
>> From: Matthias Brugger <matthias.bgg@gmail.com>
>>
>> Function drm_gem_shmem_create_with_mnt() creates an object
>> without using the mountpoint if gemfs is NULL.
>>
>> Drop the else branch calling drm_gem_shmem_create().
>>
>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>> ---
>>   drivers/gpu/drm/v3d/v3d_bo.c | 7 +------
>>   1 file changed, 1 insertion(+), 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/v3d/v3d_bo.c b/drivers/gpu/drm/v3d/v3d_bo.c
>> index 
>> 7055f7c7bcfe5700aee10b09ecc0005197323b01..f6df9e0947b6ee06043cdbb42c4f98a71bdeba4d 100644
>> --- a/drivers/gpu/drm/v3d/v3d_bo.c
>> +++ b/drivers/gpu/drm/v3d/v3d_bo.c
>> @@ -157,13 +157,8 @@ struct v3d_bo *v3d_bo_create(struct drm_device *dev, 
>> struct drm_file *file_priv,
>>       struct v3d_bo *bo;
>>       int ret;
>> -    /* Let the user opt out of allocating the BOs with THP */
>> -    if (v3d->gemfs)
>> -        shmem_obj = drm_gem_shmem_create_with_mnt(dev, unaligned_size,
>> +    shmem_obj = drm_gem_shmem_create_with_mnt(dev, unaligned_size,
>>                                 v3d->gemfs);
> 
> Please, run scripts/checkpatch.pl before sending the patch.
> 

I did with b4 prep --check which gave no errors, just double checked with:
$ ./scripts/checkpatch.pl 
0001-drm-v3d-Drop-allocation-of-object-without-mountpoint.patch
total: 0 errors, 0 warnings, 14 lines checked

0001-drm-v3d-Drop-allocation-of-object-without-mountpoint.patch has no obvious 
style problems and is ready for submission.

I suppose you want line "v3d->gemfs" to get an extra tab, correct?

Regards,
Matthias

> Best Regards,
> - Maíra
> 
>> -    else
>> -        shmem_obj = drm_gem_shmem_create(dev, unaligned_size);
>> -
>>       if (IS_ERR(shmem_obj))
>>           return ERR_CAST(shmem_obj);
>>       bo = to_v3d_bo(&shmem_obj->base);
>>
>> ---
>> base-commit: dec9255a128e19c5fcc3bdb18175d78094cc624d
>> change-id: 20241028-v3d-1d2546ed92d7
>>
>> Best regards,
>