From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8CF013A9D95 for ; Thu, 5 Feb 2026 11:38:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770291539; cv=none; b=TwPVCjfN1xrECjkGyH9UiFI8c4QSV6hn28hbuK3mdSC/CFJvqDqfpeZvRKaKGtbvap9v+MyG8IeHTuMqwwuhJGldeCPFaAtFfcZ9wrwdTawp7TKNOQ4Xf/y6qRIo1/Z7NuxJGTfUtY8Oq8JWBPzJCOTcrr02KjGPL8DUdiINDBs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770291539; c=relaxed/simple; bh=gXe3eaTM27lII25U1x8HB7oqFXGFlijd/rIF3nCm5Yk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=imQfMBXuSfXgfbOwi9l3yUEnxSxdBdhpNYqTafOv4r4U5LBqDk55zPZZRRBaUw808RRF8rlsxgH316GwT36HMiQqArYko+k/V/Rv1XX7SsDRL4kP6ys6HpTFD5DdhA3tbvhWLmt+UgXr9G5CGJrwORsnfyxcRGev/csaS0p1DBo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=PYjsob5Y; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=l/qmcDfz; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="PYjsob5Y"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="l/qmcDfz" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770291538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=gXe3eaTM27lII25U1x8HB7oqFXGFlijd/rIF3nCm5Yk=; b=PYjsob5YfxyAzVcUjF0nLkpeHXcPXDzI+xaHrrh+ZFIE60wATVWc/y/sF7PBXU3IHA/saa pxKulwqMQCdJoyflSF3cjx9Fcw/dDUGh4/evuFlSgG3ri3ACA3dTlz1b9Je87qPmpYP/xJ /ZVQvHAwrP6KrNbEVyiNX+bPBzySCFo= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-15-wyFhvnFMNPK0fP9jdMADuA-1; Thu, 05 Feb 2026 06:38:57 -0500 X-MC-Unique: wyFhvnFMNPK0fP9jdMADuA-1 X-Mimecast-MFC-AGG-ID: wyFhvnFMNPK0fP9jdMADuA_1770291536 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-43065ad16a8so585930f8f.1 for ; Thu, 05 Feb 2026 03:38:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1770291536; x=1770896336; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=gXe3eaTM27lII25U1x8HB7oqFXGFlijd/rIF3nCm5Yk=; b=l/qmcDfzQ2r1/K6K5qherwkg8ic6dKzYU0gSvjEdbaZHwvNGwCBTzewmd1/B13QKvb bnBx1WZsxn8hPG2CL7//ClUK4mICO1eTm2xyEjs/jLjKkM6lgIblNy82vhCCMTYKKX72 iFRfNa39T6iwU3xYKgD22TZOGaPUHMPR8RDMpeev0Ki+1+DWh3Vczs5lVRDzK+H3jffo kdjGuJXV7NlzWe/m/7q7pJu9KPRT7n87HEHsy1UGNHuHny09COroM9dnyOSF2UDJw9Qh SS9R+zuXW/ZepuWP3Bj8IUxPZGDzCzYmNwGLAsmbI53fPjIqAbGt3ddYZkurFbTyQP8S IZng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770291536; x=1770896336; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gXe3eaTM27lII25U1x8HB7oqFXGFlijd/rIF3nCm5Yk=; b=HK+ISir6isVClJYDKWfmfG3gzcXgzwI7LJncz5vmUWsTFmDm9guOg1qCLbeIFj+OVy TjwUxrDJ8zet3B2i1vwDvp/8UZkK2zp1Xf9+Pvi89gGBiHyWfsHv3R0L7No2arfItevA Z/kD3xj6MWhUKBCKurBQ3NM+1MMhCkYFTbEfo4SiaJwc+ngbVkITzI7sxuhGTQAlRUzu 9wT+KQ6jrtFbIU662kMw6xvnhhiiEpDUGvVfQgo8XalDjADTvo4VncBXVxgDazP78AzX pjfbym5ybEYQHd4cHugphOfYndcuY9m/6M8W9lxFdL1VmWp/1vJ27Do4qW3N/yMpJdEL YVVg== X-Forwarded-Encrypted: i=1; AJvYcCV+yMA1raMBHY7yK0/N1d7nFpA+ojHaeoE6iwD8skIeo3PiOGHwhT0Jv+6ycbmq/WJhp4v0JE+kcCr6eno=@vger.kernel.org X-Gm-Message-State: AOJu0YwS9AkY9ZyNYsiqOleoNd8F0kgKp6gZAAQjF9cW/EwydG8uw7+h jWrzm/7ru2NdJmtxjby2MEWmbdiVnKL+5KviqH9ZTxuxZrCd8MEeAsUJQkJLrIQMPKh3+MWag7E CJQXdkaQeOmgDr0StrISSiuf3AJ5ylaAW0QCPdqcHTnAFW6eVvwyLkVtp84BevvVVTA== X-Gm-Gg: AZuq6aLBsUo55ZDTDv6G9O8NuMkNHX4xiU0HFx0L0xQJAWoG4T8xszjgwzfzxbCefPR 9F0AtyVwt4+JSYgXFU2biYn1AFTcLcFs0Zs3aW5FGucOUOieoI6RYqbMRNiObA+g/vPU8Wmz01T RFon6+U3r6cXRNi0XwMatr/OJqy4bqVaZpW3fpYDVGyY+nRgNFRO3vjQzk2jYZ/p/jkkLGkV6ki E+B1DOeYyKOykfTzA6iTEwbYeTILNyswpP7unNSIxSq5EYWxtWT/uD9U7uMV1Wrf2JhLCDJhjf9 uIb4k0wqmzOkuJ4ZTrhCLWx/aao7c7yfMiyExKFWtijTxlBsGlkMDNTOkkr87uYi+WINPU84/tE pDZrk3WQBomaRjW7wOsaPje1vdxF0v6LUNrQ1mv8+qs3T3otzWoD5MHpH6Vcbb5eCDrZpTjUe+A Dozl0QHgOt X-Received: by 2002:a05:6000:2505:b0:435:8f1b:bb32 with SMTP id ffacd0b85a97d-43618052866mr8883270f8f.32.1770291535943; Thu, 05 Feb 2026 03:38:55 -0800 (PST) X-Received: by 2002:a05:6000:2505:b0:435:8f1b:bb32 with SMTP id ffacd0b85a97d-43618052866mr8883213f8f.32.1770291535457; Thu, 05 Feb 2026 03:38:55 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (185-132-178-103.hosted-by-worldstream.net. [185.132.178.103]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43617e37e78sm14247335f8f.10.2026.02.05.03.38.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Feb 2026 03:38:55 -0800 (PST) Message-ID: <495e8eaa248302b09e5049d9ec90b12f2c159016.camel@redhat.com> Subject: Re: [PATCH v2 18/20] rv/rvgen: fix unbound loop variable warning From: Gabriele Monaco To: Wander Lairson Costa Cc: Steven Rostedt , Nam Cao , "open list:RUNTIME VERIFICATION (RV)" , open list Date: Thu, 05 Feb 2026 12:38:54 +0100 In-Reply-To: <20260204144914.104028-19-wander@redhat.com> References: <20260204144914.104028-1-wander@redhat.com> <20260204144914.104028-19-wander@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2026-02-04 at 11:42 -0300, Wander Lairson Costa wrote: > Pyright static analysis reports a "possibly unbound variable" warning > for the loop variable `i` in the `abbreviate_atoms` function. The > variable is accessed after the inner loop terminates to slice the atom > string. While the loop logic currently ensures execution, the analyzer > flags the reliance on the loop variable persisting outside its scope. >=20 > Refactor the prefix length calculation into a nested `find_share_length` > helper function. This encapsulates the search logic and uses explicit > return statements, ensuring the length value is strictly defined. This > satisfies the type checker and improves code readability without > altering the runtime behavior. >=20 > Signed-off-by: Wander Lairson Costa Looks good, that's probably the pythonic way then! Reviewed-by: Gabriele Monaco > --- > =C2=A0tools/verification/rvgen/rvgen/ltl2k.py | 14 +++++++++----- > =C2=A01 file changed, 9 insertions(+), 5 deletions(-) >=20 > diff --git a/tools/verification/rvgen/rvgen/ltl2k.py > b/tools/verification/rvgen/rvgen/ltl2k.py > index fa9ea6d597095..2c564cc937235 100644 > --- a/tools/verification/rvgen/rvgen/ltl2k.py > +++ b/tools/verification/rvgen/rvgen/ltl2k.py > @@ -43,13 +43,17 @@ def abbreviate_atoms(atoms: list[str]) -> list[str]: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 skip =3D ["is", "by", "o= r", "and"] > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return '_'.join([x[:2] f= or x in s.lower().split('_') if x not in > skip]) > =C2=A0 > -=C2=A0=C2=A0=C2=A0 abbrs =3D [] > -=C2=A0=C2=A0=C2=A0 for atom in atoms: > +=C2=A0=C2=A0=C2=A0 def find_share_length(atom: str) -> int: > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 for i in range(len(atom)= , -1, -1): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = if sum(a.startswith(atom[:i]) for a in atoms) > 1: > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 break > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 share =3D atom[:i] > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unique =3D atom[i:] > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 return i > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return 0 > + > +=C2=A0=C2=A0=C2=A0 abbrs =3D [] > +=C2=A0=C2=A0=C2=A0 for atom in atoms: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 share_len =3D find_share_leng= th(atom) > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 share =3D atom[:share_len] > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 unique =3D atom[share_len:] > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 abbrs.append((shorten(sh= are) + shorten(unique))) > =C2=A0=C2=A0=C2=A0=C2=A0 return abbrs > =C2=A0