From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firewire: cdev: fix documentation of FW_CDEV_IOC_GET_INFO
Date: Sun, 04 Jan 2009 01:52:38 +0100 [thread overview]
Message-ID: <49600856.8030500@s5r6.in-berlin.de> (raw)
In-Reply-To: <tkrat.c7deb6ca39b7041e@s5r6.in-berlin.de>
I wrote:
> The FW_CDEV_IOC_GET_INFO ioctl looks at client->device->config_rom, not
> at the local node's config ROM.
>
> We could fix the implementation or the documentation. I believe the way
> how it is currently implemented is more useful than the way how it is
> currently documented, hence let's change only the documentation.
...
> * struct fw_cdev_get_info - General purpose information ioctl
...
> * @rom: If non-zero, address of a buffer to be filled by a copy of the
> - * local node's configuration ROM
> + * device's configuration ROM
Of course libdc1394 uses the ABI already as implemented, not as documented.
--
Stefan Richter
-=====-==--= ---= --=--
http://arcgraph.de/sr/
prev parent reply other threads:[~2009-01-04 0:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-02 11:47 Stefan Richter
2009-01-04 0:52 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49600856.8030500@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®