mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Guzman Lugo, Fernando" <fernando.lugo@ti.com>
To: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "Kanigeri, Hari" <h-kanigeri2@ti.com>,
	"Hiroshi.DOYU@nokia.com" <Hiroshi.DOYU@nokia.com>
Subject: RE: [PATCH] iommu: fix end address of vm area comparation in alloc_iovm_area
Date: Mon, 16 Aug 2010 23:48:14 -0500	[thread overview]
Message-ID: <496565EC904933469F292DDA3F1663E602CA4D894C@dlee06.ent.ti.com> (raw)
In-Reply-To: <496565EC904933469F292DDA3F1663E602CA4D8949@dlee06.ent.ti.com>


There was a mistake with Hiroshi email. Looping in Hiroshi

Sorry for the noise.

Regards,
Fernando.
________________________________________
From: linux-omap-owner@vger.kernel.org [linux-omap-owner@vger.kernel.org] On Behalf Of Guzman Lugo, Fernando [fernando.lugo@ti.com]
Sent: Monday, August 16, 2010 10:51 PM
To: linux-omap@vger.kernel.org; linux-kernel@vger.kernel.org
Cc: Hiroshi.DOYO@nokia.com; Kanigeri, Hari
Subject: [PATCH] iommu: fix end address of vm area comparation in alloc_iovm_area

>From cc48c0adaee97c8385a356aefa5b64a51818b4fd Mon Sep 17 00:00:00 2001
From: Fernando Guzman Lugo <x0095840@ti.com>
Date: Mon, 16 Aug 2010 22:28:24 -0500
Subject: [PATCH] iommu: fix end address of vm area comparation in alloc_iovm_area

End address of the vm area is “start + bytes -1”,
not “start + byte”. This patch fixes that issue by doing
an inclusive comparison with tmp->da_start. This issue
was preventing allocate an area of size exactly the same
than the free area. I did no change the value of da_end
of each vm area because it is used to get area size in
several places.

Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com>
---
 arch/arm/plat-omap/iovmm.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/plat-omap/iovmm.c b/arch/arm/plat-omap/iovmm.c
index b8bcad5..8745d4e 100644
--- a/arch/arm/plat-omap/iovmm.c
+++ b/arch/arm/plat-omap/iovmm.c
@@ -295,7 +295,7 @@ static struct iovm_struct *alloc_iovm_area(struct iommu *obj, u32 da,
        prev_end = 0;
        list_for_each_entry(tmp, &obj->mmap, list) {

-               if ((prev_end <= start) && (start + bytes < tmp->da_start))
+               if ((prev_end <= start) && (start + bytes <= tmp->da_start))
                        goto found;

                if (flags & IOVMF_DA_ANON)
--
1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2010-08-17  4:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-17  3:51 Guzman Lugo, Fernando
2010-08-17  4:48 ` Guzman Lugo, Fernando [this message]
2010-08-17  5:27   ` Hiroshi DOYU
2010-08-17  6:08     ` Guzman Lugo, Fernando
2010-08-17 16:56 Fernando Guzman Lugo
2010-10-10 16:38 ` Felipe Contreras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=496565EC904933469F292DDA3F1663E602CA4D894C@dlee06.ent.ti.com \
    --to=fernando.lugo@ti.com \
    --cc=Hiroshi.DOYU@nokia.com \
    --cc=h-kanigeri2@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®