From: "Guzman Lugo, Fernando" <fernando.lugo@ti.com>
To: "Kanigeri, Hari" <h-kanigeri2@ti.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "ohad@wizery.com" <ohad@wizery.com>,
"hiroshi.doyu@nokia.com" <hiroshi.doyu@nokia.com>,
"ameya.palande@nokia.com" <ameya.palande@nokia.com>,
"felipe.contreras@nokia.com" <felipe.contreras@nokia.com>
Subject: RE: [PATCH 8/9] dspbridge: add map support for big buffers
Date: Fri, 2 Jul 2010 11:27:09 -0500 [thread overview]
Message-ID: <496565EC904933469F292DDA3F1663E602CBDD3ADE@dlee06.ent.ti.com> (raw)
In-Reply-To: <8F7AF80515AF0D4D93307E594F3CB40E4CAD34D5@dlee03.ent.ti.com>
Hi Hari,
> -----Original Message-----
> From: Kanigeri, Hari
> Sent: Thursday, July 01, 2010 6:36 PM
> To: Guzman Lugo, Fernando; linux-omap@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Cc: ohad@wizery.com; hiroshi.doyu@nokia.com; ameya.palande@nokia.com;
> felipe.contreras@nokia.com; Guzman Lugo, Fernando
> Subject: RE: [PATCH 8/9] dspbridge: add map support for big buffers
>
> Fernando,
>
> > - for_each_sg(sgt->sgl, sg, sgt->nents, i)
> > - sg_set_page(sg, usr_pgs[i], PAGE_SIZE, 0);
> > + da = iommu_vmap(mmu, da, sgt, IOVMF_ENDIAN_LITTLE |
> > + IOVMF_ELSZ_32);
>
> -- iommu_vmap does the Kernel mapping to the buffers you are mapping to
> DSP MMU. Why do you need Kernel mappings ?
>
> If there is no benefit in maintaining Kernel mapping I would rather call
> iopgtable_store_entry directly to map the entries.
Where inside iommu_vmap is the mapping done? I thought the kernel can access to that buffer after get_user_pages() where the user pages are pin and we can get a kernel address. The intention using iommu_vmap was to use api's proved by the iovmmu module. iommu_vmap() it is also tracking the mapped areas, so maybe the next step could be: remove dmm.c/h files and also proc_reserve/unreserved functions. If you think the function is unneeded steps and could affect the performance I can do the change to use only iopgtable_store_entry().
I think a kernel mapping is needed for flush/invalidate api's, please correct me if I am wrong.
Regards,
Fernando.
>
> Thank you,
> Best regards, Hari
next prev parent reply other threads:[~2010-07-02 16:27 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-01 0:20 [PATCH 0/9] dspbridge: iommu migration Fernando Guzman Lugo
2010-07-01 0:20 ` [PATCH 1/9] dspbridge: replace iommu custom for opensource implementation Fernando Guzman Lugo
2010-07-01 0:20 ` [PATCH 2/9] dspbridge: move shared memory iommu maps to tiomap3430.c Fernando Guzman Lugo
2010-07-01 0:20 ` [PATCH 3/9] dspbridge: rename bridge_brd_mem_map/unmap to a proper name Fernando Guzman Lugo
2010-07-01 0:20 ` [PATCH 4/9] dspbridge: remove custom mmu code from tiomap3430.c Fernando Guzman Lugo
2010-07-01 0:20 ` [PATCH 5/9] dspbridge: add mmufault support Fernando Guzman Lugo
2010-07-01 0:20 ` [PATCH 6/9] dspbridge: remove hw directory Fernando Guzman Lugo
2010-07-01 0:20 ` [PATCH 7/9] dspbridge: move all iommu related code to a new file Fernando Guzman Lugo
2010-07-01 0:20 ` [PATCH 8/9] dspbridge: add map support for big buffers Fernando Guzman Lugo
2010-07-01 0:21 ` [PATCH 9/9] dspbridge: cleanup bridge_dev_context and cfg_hostres structures Fernando Guzman Lugo
2010-07-01 23:36 ` [PATCH 8/9] dspbridge: add map support for big buffers Kanigeri, Hari
2010-07-02 16:27 ` Guzman Lugo, Fernando [this message]
2010-07-02 17:02 ` Kanigeri, Hari
2010-07-02 18:39 ` Guzman Lugo, Fernando
2010-08-24 10:09 ` Felipe Contreras
2010-08-24 16:31 ` Guzman Lugo, Fernando
2010-08-24 17:46 ` Felipe Contreras
2010-08-24 18:44 ` Guzman Lugo, Fernando
2010-08-24 18:55 ` Felipe Contreras
2010-08-24 19:05 ` Guzman Lugo, Fernando
2010-08-24 19:13 ` Felipe Contreras
2010-08-24 19:30 ` Guzman Lugo, Fernando
2010-08-24 21:17 ` Felipe Contreras
2010-08-24 21:55 ` Guzman Lugo, Fernando
2010-08-25 6:05 ` Felipe Contreras
2010-08-25 16:00 ` Guzman Lugo, Fernando
2010-08-25 19:18 ` Felipe Contreras
2010-08-25 19:42 ` Guzman Lugo, Fernando
2010-08-26 10:04 ` Felipe Contreras
2010-08-26 13:00 ` Guzman Lugo, Fernando
2010-08-26 6:55 ` FUJITA Tomonori
2010-08-26 12:38 ` Guzman Lugo, Fernando
2010-08-26 12:56 ` FUJITA Tomonori
2010-08-26 13:16 ` Guzman Lugo, Fernando
2010-08-26 14:03 ` FUJITA Tomonori
2010-08-26 14:13 ` Guzman Lugo, Fernando
2010-07-02 6:27 ` [PATCH 5/9] dspbridge: add mmufault support Hiroshi DOYU
2010-07-02 16:37 ` Guzman Lugo, Fernando
2010-07-02 6:32 ` [PATCH 1/9] dspbridge: replace iommu custom for opensource implementation Hiroshi DOYU
2010-07-02 16:40 ` Guzman Lugo, Fernando
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496565EC904933469F292DDA3F1663E602CBDD3ADE@dlee06.ent.ti.com \
--to=fernando.lugo@ti.com \
--cc=ameya.palande@nokia.com \
--cc=felipe.contreras@nokia.com \
--cc=h-kanigeri2@ti.com \
--cc=hiroshi.doyu@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®