From: "Guzman Lugo, Fernando" <fernando.lugo@ti.com>
To: Hiroshi DOYU <Hiroshi.DOYU@nokia.com>
Cc: "felipe.contreras@nokia.com" <felipe.contreras@nokia.com>,
"tony@atomide.com" <tony@atomide.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: RE: [PATCH 3/4] iovmm: replace __iounmap with omap_iounmap
Date: Thu, 14 Oct 2010 11:11:50 -0500 [thread overview]
Message-ID: <496565EC904933469F292DDA3F1663E602F47B37F4@dlee06.ent.ti.com> (raw)
In-Reply-To: <20101014.124710.71089824.Hiroshi.DOYU@nokia.com>
> -----Original Message-----
> From: Hiroshi DOYU [mailto:Hiroshi.DOYU@nokia.com]
> Sent: Thursday, October 14, 2010 4:47 AM
> To: Guzman Lugo, Fernando
> Cc: felipe.contreras@nokia.com; tony@atomide.com;
> linux-kernel@vger.kernel.org; andy.shevchenko@gmail.com;
> linux-omap@vger.kernel.org
> Subject: Re: [PATCH 3/4] iovmm: replace __iounmap with omap_iounmap
>
> From: "ext Guzman Lugo, Fernando" <fernando.lugo@ti.com>
> Subject: RE: [PATCH 3/4] iovmm: replace __iounmap with omap_iounmap
> Date: Thu, 14 Oct 2010 10:18:30 +0200
>
> >
> >> ________________________________________
> >> From: Hiroshi DOYU [Hiroshi.DOYU@nokia.com]
> >> Sent: Thursday, October 14, 2010 1:45 AM
> >> To: Guzman Lugo, Fernando
> >> Cc: felipe.contreras@nokia.com; tony@atomide.com;
> >> linux-kernel@vger.kernel.org; andy.shevchenko@gmail.com;
> >> linux-omap@vger.kernel.org
> >> Subject: Re: [PATCH 3/4] iovmm: replace __iounmap with omap_iounmap
> >>
> >> Hi Fernando,
> >>
> >> From: ext Fernando Guzman Lugo <x0095840@ti.com>
> >> Subject: [PATCH 3/4] iovmm: replace __iounmap with omap_iounmap
> >> Date: Thu, 14 Oct 2010 04:27:36 +0200
> >>
> >> > Omap platform is omap_iounmap function.
> >> >
> >> > Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com>
> >> > ---
> >> > arch/arm/plat-omap/iovmm.c | 2 +-
> >> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >> >
> >> > diff --git a/arch/arm/plat-omap/iovmm.c
> >> > b/arch/arm/plat-omap/iovmm.c index 93a34d9..5489ca9 100644
> >> > --- a/arch/arm/plat-omap/iovmm.c
> >> > +++ b/arch/arm/plat-omap/iovmm.c
> >> > @@ -821,7 +821,7 @@ void iommu_kunmap(struct iommu *obj, u32 da)
> >> > struct sg_table *sgt;
> >> > typedef void (*func_t)(const void *);
> >> >
> >> > - sgt = unmap_vm_area(obj, da, (func_t)__iounmap,
> >>
> >> + sgt = unmap_vm_area(obj, da, (func_t)iounmap,
> >>
> >> Woundn't the above be enough?
> >>
> >> Eventually this "iounmap()" calls "__arch_iounmap()" ->
> >> "omap_iounmap()". I don't see any special reason to call
> >> "omap_iounmap()" here for now.
> >
> > iounmap and __arch_iounmap are macros they cannot not be
> used there.
> > If so, it gives a "undeclared" compile error.
>
> Ok. I'll add this explanation as a note on this commit.
>
Sure, Thanks.
Regards,
Fernando.
prev parent reply other threads:[~2010-10-14 16:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 2:27 [PATCHv3 0/4] iovmm: fixes for iovmm module Fernando Guzman Lugo
2010-10-14 2:27 ` [PATCH 1/4] iovmm: no gap checking for fixed address Fernando Guzman Lugo
2010-10-14 2:27 ` [PATCH 2/4] iovmm: add superpages support to fixed da address Fernando Guzman Lugo
2010-10-14 2:27 ` [PATCH 3/4] iovmm: replace __iounmap with omap_iounmap Fernando Guzman Lugo
2010-10-14 2:27 ` [PATCH 4/4] iommu: create new api to set valid da range Fernando Guzman Lugo
2010-10-14 6:45 ` [PATCH 3/4] iovmm: replace __iounmap with omap_iounmap Hiroshi DOYU
2010-10-14 8:18 ` Guzman Lugo, Fernando
2010-10-14 9:47 ` Hiroshi DOYU
2010-10-14 16:11 ` Guzman Lugo, Fernando [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496565EC904933469F292DDA3F1663E602F47B37F4@dlee06.ent.ti.com \
--to=fernando.lugo@ti.com \
--cc=Hiroshi.DOYU@nokia.com \
--cc=andy.shevchenko@gmail.com \
--cc=felipe.contreras@nokia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®