From: Niels de Vos <niels.devos@wincor-nixdorf.com>
To: Eugene Teo <eugeneteo@kernel.org>
Cc: linux-kernel@vger.kernel.org, rolandd@cisco.com,
sean.hefty@intel.com, hal.rosenstock@gmail.com
Subject: Re: [PATCH] IB: check for memory allocation failure [v2]
Date: Thu, 08 Jan 2009 16:33:44 +0100 [thread overview]
Message-ID: <49661CD8.9060400@wincor-nixdorf.com> (raw)
In-Reply-To: <28fa9c5e0901080620g7f4707daxbffc9bf798581882@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 714 bytes --]
Eugene Teo wrote:
> On Thu, Jan 8, 2009 at 10:05 PM, Niels de Vos
> <niels.devos@wincor-nixdorf.com> wrote:
>> Hi Eugene,
>>
>> please see below.
>
> Thanks for reviewing. Here's an updated patch:
>
> Fix error-path NULL deref in c2_register_device().
>
> Signed-off-by: Eugene Teo <eugeneteo@kernel.org>
(note: your patch was attached, not inlined...)
There is also an additional kfree() at the end of the patch. It wasn't
included in the first version you sent. Looks correct now imho.
Reviewed-by: Niels de Vos <niels.devos@wincor-nixdorf.com>
> ---
> drivers/infiniband/hw/amso1100/c2_provider.c | 17 ++++++++++++-----
> 1 file changed, 12 insertions(+), 5 deletions(-)
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2009-01-08 15:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 14:20 Eugene Teo
2009-01-08 15:33 ` Niels de Vos [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49661CD8.9060400@wincor-nixdorf.com \
--to=niels.devos@wincor-nixdorf.com \
--cc=eugeneteo@kernel.org \
--cc=hal.rosenstock@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rolandd@cisco.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®