From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933087AbcIBRYP (ORCPT ); Fri, 2 Sep 2016 13:24:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50286 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932495AbcIBRYM (ORCPT ); Fri, 2 Sep 2016 13:24:12 -0400 Subject: Re: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp To: Steve Wise , "'Baoyou Xie'" , sean.hefty@intel.com, hal.rosenstock@gmail.com References: <1472396231-16937-1-git-send-email-baoyou.xie@linaro.org> <004001d20201$448119e0$cd834da0$@opengridcomputing.com> Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@linaro.org, xie.baoyou@zte.com.cn From: Doug Ledford Message-ID: <496842ea-a04f-431b-5eee-6ef6535375ee@redhat.com> Date: Fri, 2 Sep 2016 13:23:47 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <004001d20201$448119e0$cd834da0$@opengridcomputing.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hfXHp4maHOdWL5oCO7CotNmMbBDcNsJhV" X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Fri, 02 Sep 2016 17:24:11 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hfXHp4maHOdWL5oCO7CotNmMbBDcNsJhV Content-Type: multipart/mixed; boundary="QdmxHnDg005JeXkGWhlpjqqqH4lKqx6Mg"; protected-headers="v1" From: Doug Ledford To: Steve Wise , 'Baoyou Xie' , sean.hefty@intel.com, hal.rosenstock@gmail.com Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@linaro.org, xie.baoyou@zte.com.cn Message-ID: <496842ea-a04f-431b-5eee-6ef6535375ee@redhat.com> Subject: Re: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp References: <1472396231-16937-1-git-send-email-baoyou.xie@linaro.org> <004001d20201$448119e0$cd834da0$@opengridcomputing.com> In-Reply-To: <004001d20201$448119e0$cd834da0$@opengridcomputing.com> --QdmxHnDg005JeXkGWhlpjqqqH4lKqx6Mg Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 8/29/2016 10:26 AM, Steve Wise wrote: >> Subject: [PATCH v3] IB/cxgb4: Mark symbols static for _free_qp >> >> We get 1 warning when build kernel with W=3D1: >> drivers/infiniband/hw/cxgb4/qp.c:686:6: warning: no previous prototype= for >> '_free_qp' [-Wmissing-prototypes] >> >> In fact, this function is only used in the file in which it is declare= d >> and don't need a declaration, but can be made static. >> so this patch marks it 'static'. >> >> Signed-off-by: Baoyou Xie >> Reviewed-by: Yuval Shaia >> Reviewed-by: Leon Romanovsky >=20 > Ignore my comment on v2... >=20 > Acked-by: Steve Wise >=20 Thanks, applied. --=20 Doug Ledford GPG Key ID: 0E572FDD --QdmxHnDg005JeXkGWhlpjqqqH4lKqx6Mg-- --hfXHp4maHOdWL5oCO7CotNmMbBDcNsJhV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJXybWjAAoJELgmozMOVy/d89QP/3I5hCXed95bL2FNubOhHuQF 0MeU6jCQkFnYHYsKIbIEyCI0b63VzOCN/HqglyWj5DNj+NarZsUQOGCB1Q5wybot Fhc3h+WZirkLCSDpfvbqjlGraW9MQ6D07o2qjYZbiaucMIxgKAlfYh1BABYzonUv q/x+ADjM0bUTt2oGWE3olLehua+7fJ42MV9jvnIomedrskWTmWi7k39KjT+d8BV2 aHl8kMiPCmP3JFo5qzMyAtOPIepOvGJqqhvWd6x68vdrmn01mSJOl4LWZXETjtIg SYgBYgrSS2apB0axOhNh5wU6a8GLZZndYOgjNrYy8nMJVUCm4ShByx8BZewzuzqx lQ3+GMza/VP+9ufOfztt66YC+vUJsdQotKHDG/dt5TdD9r8wC9lOCk2a/Xtmu173 sF2/x+HOuKFc8kazJbeVpokB6WDlFkIMGvq0ijeIB412vnLtaXN/mdMj0HUHV44F q8kJgHHFPBoqvqWYdoP68NrTfkjF+KK8rh73xWdMwtgkmzqFhJLxDv1+nAxh/i+9 Su/qomo/DGeVT55YQuM3Pagg1iqzklcS23FqyrBaMthAqluPEggSv0GmNT3aJSnK 8tphBL9/NInfGc2h0scJ7OqkbchS9HuwETiW52cW8pXcvU2+KvbJDiIrngKAbJCK w1QPkWQoCJtvCuX641op =ddK6 -----END PGP SIGNATURE----- --hfXHp4maHOdWL5oCO7CotNmMbBDcNsJhV--