From: Jon Hunter <jonathanh@nvidia.com>
To: Prathamesh Shete <pshete@nvidia.com>,
linus.walleij@linaro.org, brgl@bgdev.pl,
thierry.reding@gmail.com, linux-tegra@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: smangipudi@nvidia.com, Manish Bhardwaj <mbhardwaj@nvidia.com>
Subject: Re: [PATCH] gpio: tegra186: Check PMC driver status before any request
Date: Wed, 7 Jun 2023 11:55:24 +0100 [thread overview]
Message-ID: <496889ff-dd61-51af-c716-b9b9e2300be7@nvidia.com> (raw)
In-Reply-To: <56dcfcff-3b36-25ea-eb72-2b9d2f8f3883@nvidia.com>
On 06/06/2023 09:53, Jon Hunter wrote:
>
> On 06/06/2023 08:17, Prathamesh Shete wrote:
>> This patch fixes the issue where even if PMC driver status is
>> disabled still we are trying to look up for the IRQ domain
>> that PMC driver would've registered if it had been enabled.
>
> It might be clearer to say ...
>
> When the PMC device is disabled, probing of the Tegra186 GPIO driver
> fails because the IRQ domain that is registered by the PMC driver is not
> found. Fix this by checking to see if the PMC device is enabled before
> attempting to lookup the IRQ domain registered by the PMC.
It could also be worth noting that it is OK to skip the PMC IRQ domain
in this case because this only impacts wake-ups and not GPIO
functionality in general.
Jon
--
nvpublic
next prev parent reply other threads:[~2023-06-07 10:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 7:17 Prathamesh Shete
2023-06-06 8:53 ` Jon Hunter
2023-06-07 10:55 ` Jon Hunter [this message]
2023-06-07 11:31 ` [PATCH v2] " Prathamesh Shete
2023-06-07 11:46 ` Jon Hunter
2023-06-08 16:02 ` Thierry Reding
2023-06-06 9:48 ` [PATCH] " andy.shevchenko
2023-06-09 7:18 ` Linus Walleij
-- strict thread matches above, loose matches on Subject: below --
2022-09-12 13:33 Prathamesh Shete
2022-10-24 14:02 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496889ff-dd61-51af-c716-b9b9e2300be7@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mbhardwaj@nvidia.com \
--cc=pshete@nvidia.com \
--cc=smangipudi@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®