From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0633FBA37 for ; Wed, 10 Apr 2024 08:29:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712737770; cv=none; b=ayJoZQSg3+dzC6Ul+6nvPEG7tRhsGIFND/pkwGuvevW5nr5KZCn5sAnjoMCe4iwAEQghgsGzgUhe1uA+ibfFIRIl69CI/YrJLGZtwJtyyklKO+GiTeeDicm4oStGVwhh7u4r2ocbH00oAulZdUf7iKKqC8L4QvCyMTHzO4JEE8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712737770; c=relaxed/simple; bh=oA1OroOV76SMR8urGwhuYEaO4AxVjvhxMhUOgmibY7k=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=u7SQv/VIb0zfHQIAO2tfDQDzqepxESsae4MHr2sdv5MoW4XiN2JlwGcdY3jd+n45kDcNsQaro60HGQHh+sLXRkvL9m9+1LbMRpEaCFabEyttC9X+zkQFM68n0TixGHNp28A3HdItV8xegkxNJSOu/JI9ZOlbk2euInrk5q/cPZ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ruTKg-0007cr-Fg; Wed, 10 Apr 2024 10:29:26 +0200 Received: from [2a0a:edc0:0:900:1d::4e] (helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ruTKf-00BSdI-RC; Wed, 10 Apr 2024 10:29:25 +0200 Received: from pza by lupine with local (Exim 4.96) (envelope-from ) id 1ruTKf-000463-2X; Wed, 10 Apr 2024 10:29:25 +0200 Message-ID: <4969fb7a602fca2354b8d812a0f48bf495d7941e.camel@pengutronix.de> Subject: Re: [PATCH 4/4] gpu: ipu-v3: Convert to platform remove callback returning void From: Philipp Zabel To: Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= , David Airlie , Daniel Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Wed, 10 Apr 2024 10:29:25 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Di, 2024-04-09 at 19:02 +0200, Uwe Kleine-K=C3=B6nig wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. >=20 > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). >=20 > Trivially convert the ipu-v3 platform drivers from always returning zero > in the remove callback to the void returning variant. >=20 > Signed-off-by: Uwe Kleine-K=C3=B6nig Reviewed-by: Philipp Zabel regards Philipp