From: "Jan Beulich" <jbeulich@novell.com>
To: <mingo@elte.hu>, <tglx@linutronix.de>, <hpa@zytor.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86: avoid early crash in disable_local_APIC()
Date: Wed, 14 Jan 2009 12:28:51 +0000 [thread overview]
Message-ID: <496DE893.76E4.0078.0@novell.com> (raw)
E.g. when called due to an early panic.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
---
arch/x86/kernel/apic.c | 4 ++++
1 file changed, 4 insertions(+)
--- linux-2.6.29-rc1/arch/x86/kernel/apic.c 2009-01-14 11:36:05.000000000 +0100
+++ 2.6.29-rc1-x86-early-disable-lapic/arch/x86/kernel/apic.c 2009-01-06 16:51:35.000000000 +0100
@@ -894,6 +894,10 @@ void disable_local_APIC(void)
{
unsigned int value;
+ /* APIC hasn't been mapped yet */
+ if (!apic_phys)
+ return;
+
clear_local_APIC();
/*
next reply other threads:[~2009-01-14 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-14 12:28 Jan Beulich [this message]
2009-01-15 11:05 ` Ingo Molnar
2009-01-15 22:47 ` Ingo Molnar
2009-01-15 22:47 ` Ingo Molnar
2009-01-16 8:22 ` Jan Beulich
2009-01-16 13:09 ` Ingo Molnar
2009-01-16 21:26 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496DE893.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome