From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: "Kristian Høgsberg" <krh@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Manfred Spraul <manfred@colorfullife.com>,
dcm@acm.org, Nadia.Derbey@bull.net,
linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, paulmck@us.ibm.com
Subject: Re: [PATCH] lib/idr.c: Zero memory properly in idr_remove_all
Date: Wed, 14 Jan 2009 17:21:46 +0100 [thread overview]
Message-ID: <496E111A.9010808@s5r6.in-berlin.de> (raw)
In-Reply-To: <1231942990.8542.7.camel@gaara.bos.redhat.com>
Kristian Høgsberg wrote:
> On Tue, 2009-01-13 at 14:48 -0800, Andrew Morton wrote:
>> What do we think of just removing the constructor and using
>> kmem_cache_zalloc()?
>
> We still need to zero out the idr_layer before returning it to the idr's
> internal free list.
I think so too. But a more robust solution would IMO be to initialize
an idr_layer /before/ use, not /after/ use. Will send a patch later.
--
Stefan Richter
-=====-==--= ---= -===-
http://arcgraph.de/sr/
next prev parent reply other threads:[~2009-01-14 16:21 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 7:04 David Moore
2009-01-10 9:03 ` Stefan Richter
2009-01-10 9:15 ` Andrew Morton
2009-01-10 10:05 ` Stefan Richter
2009-01-12 15:20 ` Kristian Høgsberg
2009-01-12 19:53 ` Manfred Spraul
2009-01-12 20:38 ` Kristian Høgsberg
2009-01-12 20:50 ` Manfred Spraul
2009-01-13 22:48 ` Andrew Morton
2009-01-14 2:51 ` David Moore
2009-01-14 7:19 ` Pekka Enberg
2009-01-14 8:17 ` Andrew Morton
2009-01-14 8:59 ` Stefan Richter
2009-01-14 9:22 ` Andrew Morton
2009-01-14 9:48 ` Stefan Richter
2009-01-14 9:52 ` Stefan Richter
2009-01-14 9:02 ` Pekka Enberg
2009-01-14 14:23 ` Kristian Høgsberg
2009-01-14 16:21 ` Stefan Richter [this message]
2009-01-14 16:33 ` Kristian Høgsberg
2009-01-14 18:05 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496E111A.9010808@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=Nadia.Derbey@bull.net \
--cc=akpm@linux-foundation.org \
--cc=dcm@acm.org \
--cc=krh@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=manfred@colorfullife.com \
--cc=paulmck@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome