From: Cyrill Gorcunov <gorcunov@gmail.com>
To: mingo@elte.hu, hpa@zytor.com, linux-kernel@vger.kernel.org
Cc: harvey.harrison@gmail.com, sam@ravnborg.org,
jaswinderrajput@gmail.com, Cyrill Gorcunov <gorcunov@openvz.org>
Subject: [patch 1/5] x86: headers cleanup - boot.h
Date: Wed, 14 Jan 2009 23:37:46 +0300 [thread overview]
Message-ID: <496e4e23.1358560a.0b42.ffff8588@mx.google.com> (raw)
In-Reply-To: <20090114203745.285473388@gmail.com>
[-- Attachment #1: x86-header-boot-h --]
[-- Type: text/plain, Size: 1471 bytes --]
Impact: cleanup
'make headers_check' warn us about leaking of kernel private
(mostly compile time vars) data to userspace in headers. Fix it.
Neither BOOT_HEAP_SIZE, BOOT_STACK_SIZE refs
was found by searching thru net (ie in user-space area)
so fence this all by __KERNEL__ guard.
Signed-off-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
---
arch/x86/include/asm/boot.h | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
Index: linux-2.6.git/arch/x86/include/asm/boot.h
===================================================================
--- linux-2.6.git.orig/arch/x86/include/asm/boot.h
+++ linux-2.6.git/arch/x86/include/asm/boot.h
@@ -10,14 +10,16 @@
#define EXTENDED_VGA 0xfffe /* 80x50 mode */
#define ASK_VGA 0xfffd /* ask for it at bootup */
+#ifdef __KERNEL__
+
/* Physical address where kernel should be loaded. */
#define LOAD_PHYSICAL_ADDR ((CONFIG_PHYSICAL_START \
+ (CONFIG_PHYSICAL_ALIGN - 1)) \
& ~(CONFIG_PHYSICAL_ALIGN - 1))
-#if (defined CONFIG_KERNEL_BZIP2)
+#ifdef CONFIG_KERNEL_BZIP2
#define BOOT_HEAP_SIZE 0x400000
-#else
+#else /* !CONFIG_KERNEL_BZIP2 */
#ifdef CONFIG_X86_64
#define BOOT_HEAP_SIZE 0x7000
@@ -25,7 +27,7 @@
#define BOOT_HEAP_SIZE 0x4000
#endif
-#endif
+#endif /* !CONFIG_KERNEL_BZIP2 */
#ifdef CONFIG_X86_64
#define BOOT_STACK_SIZE 0x4000
@@ -33,4 +35,6 @@
#define BOOT_STACK_SIZE 0x1000
#endif
+#endif /* __KERNEL__ */
+
#endif /* _ASM_X86_BOOT_H */
--
next parent reply other threads:[~2009-01-14 20:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20090114203745.285473388@gmail.com>
2009-01-14 20:37 ` Cyrill Gorcunov [this message]
2009-01-14 21:04 ` Harvey Harrison
2009-01-14 21:11 ` Cyrill Gorcunov
2009-01-14 21:20 ` Cyrill Gorcunov
2009-01-14 20:37 ` [patch 2/5] x86: headers cleanup - prctl.h Cyrill Gorcunov
2009-01-14 20:37 ` [patch 3/5] x86: headers cleanup - ptrace-abi.h Cyrill Gorcunov
2009-01-14 22:21 ` H. Peter Anvin
2009-01-15 8:06 ` Metzger, Markus T
2009-01-15 8:41 ` Cyrill Gorcunov
2009-01-15 16:52 ` H. Peter Anvin
2009-01-15 17:33 ` Cyrill Gorcunov
2009-01-15 17:55 ` H. Peter Anvin
2009-01-15 18:32 ` Cyrill Gorcunov
2009-01-14 20:37 ` [patch 4/5] x86: headers cleanup - sigcontext32.h Cyrill Gorcunov
2009-01-14 20:37 ` [patch 5/5] x86: headers cleanup - setup.h Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496e4e23.1358560a.0b42.ffff8588@mx.google.com \
--to=gorcunov@gmail.com \
--cc=gorcunov@openvz.org \
--cc=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=jaswinderrajput@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome