From: lijiang <lijiang@redhat.com>
To: Baoquan He <bhe@redhat.com>
Cc: linux-kernel@vger.kernel.org, thomas.lendacky@amd.com,
iommu@lists.linux-foundation.org, dyoung@redhat.com,
kexec@lists.infradead.org
Subject: Re: [PATCH 2/4 V3] Allocate pages for kdump without encryption when SME is enabled
Date: Thu, 21 Jun 2018 21:27:23 +0800 [thread overview]
Message-ID: <49706f0e-03b6-8c43-c35f-c0b0338a17bd@redhat.com> (raw)
In-Reply-To: <20180621102321.GK29979@MiWiFi-R3L-srv>
在 2018年06月21日 18:23, Baoquan He 写道:
> On 06/21/18 at 01:06pm, lijiang wrote:
>> 在 2018年06月21日 09:53, Baoquan He 写道:
>>> On 06/16/18 at 04:27pm, Lianbo Jiang wrote:
>>>> When SME is enabled in the first kernel, we will allocate pages
>>>> for kdump without encryption in order to be able to boot the
>>>> second kernel in the same manner as kexec, which helps to keep
>>>> the same code style.
>>>>
>>>> Signed-off-by: Lianbo Jiang <lijiang@redhat.com>
>>>> ---
>>>> kernel/kexec_core.c | 12 ++++++++++++
>>>> 1 file changed, 12 insertions(+)
>>>>
>>>> diff --git a/kernel/kexec_core.c b/kernel/kexec_core.c
>>>> index 20fef1a..3c22a9b 100644
>>>> --- a/kernel/kexec_core.c
>>>> +++ b/kernel/kexec_core.c
>>>> @@ -471,6 +471,16 @@ static struct page *kimage_alloc_crash_control_pages(struct kimage *image,
>>>> }
>>>> }
>>>>
>>>> + if (pages) {
>>>> + unsigned int count, i;
>>>> +
>>>> + pages->mapping = NULL;
>>>> + set_page_private(pages, order);
>>>> + count = 1 << order;
>>>> + for (i = 0; i < count; i++)
>>>> + SetPageReserved(pages + i);
>>>
>>> I guess you might imitate the kexec case, however kexec get pages from
>>> buddy. Crash pages are reserved in memblock, these codes might make no sense.
>>>
>> Thanks for your comments.
>> We have changed the attribute of pages, so the original attribute of pages will be
>> restored when they free.
>
> Hmm, you can check what kimage_free() is doing, and where
> kimage->control_pages, dest_pages, unusable_pages is assigned. Do you
> know where these original attribute of pages comes from and they are
> used/needed in CRASH case, if you care about them?
>
Originally, we want to have an opportunity to restore the previous attribute of pages, that
should be more better if the pages are remembered in 'image->control_pages'.
If we remove these codes, it is also harmless for kdump, but it will become strange, maybe
someone could ask where to restore the previous attribute of pages.
Thanks.
>>
>>>> + arch_kexec_post_alloc_pages(page_address(pages), 1 << order, 0);
>>>> + }
>>>> return pages;
>>>> }
>>>>
>>>> @@ -865,6 +875,7 @@ static int kimage_load_crash_segment(struct kimage *image,
>>>> result = -ENOMEM;
>>>> goto out;
>>>> }
>>>> + arch_kexec_post_alloc_pages(page_address(page), 1, 0);
>>>> ptr = kmap(page);
>>>> ptr += maddr & ~PAGE_MASK;
>>>> mchunk = min_t(size_t, mbytes,
>>>> @@ -882,6 +893,7 @@ static int kimage_load_crash_segment(struct kimage *image,
>>>> result = copy_from_user(ptr, buf, uchunk);
>>>> kexec_flush_icache_page(page);
>>>> kunmap(page);
>>>> + arch_kexec_pre_free_pages(page_address(page), 1);
>>>> if (result) {
>>>> result = -EFAULT;
>>>> goto out;
>>>> --
>>>> 2.9.5
>>>>
>>>>
>>>> _______________________________________________
>>>> kexec mailing list
>>>> kexec@lists.infradead.org
>>>> http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2018-06-21 13:27 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-16 8:27 [PATCH 0/4 V3] Support kdump for AMD secure memory encryption(SME) Lianbo Jiang
2018-06-16 8:27 ` [PATCH 1/4 V3] Add a function(ioremap_encrypted) for kdump when AMD sme enabled Lianbo Jiang
2018-06-20 16:00 ` Tom Lendacky
2018-06-21 9:13 ` lijiang
2018-06-16 8:27 ` [PATCH 2/4 V3] Allocate pages for kdump without encryption when SME is enabled Lianbo Jiang
2018-06-21 1:53 ` Baoquan He
2018-06-21 5:06 ` lijiang
2018-06-21 10:23 ` Baoquan He
2018-06-21 13:27 ` lijiang [this message]
2018-06-22 2:51 ` Baoquan He
2018-06-16 8:27 ` [PATCH 3/4 V3] Remap the device table of IOMMU in encrypted manner for kdump Lianbo Jiang
2018-06-20 16:42 ` Tom Lendacky
2018-06-21 5:42 ` lijiang
2018-06-21 8:39 ` Baoquan He
2018-06-21 9:45 ` lijiang
2018-06-21 13:12 ` Tom Lendacky
2018-06-22 2:52 ` Baoquan He
2018-06-21 1:57 ` Baoquan He
2018-06-16 8:27 ` [PATCH 4/4 V3] Help to dump the old memory encrypted into vmcore file Lianbo Jiang
2018-06-19 3:16 ` Dave Young
2018-06-19 14:46 ` lijiang
2018-06-20 4:50 ` lijiang
2018-06-21 2:47 ` Baoquan He
2018-06-21 1:21 ` [PATCH 0/4 V3] Support kdump for AMD secure memory encryption(SME) Baoquan He
2018-06-21 3:18 ` lijiang
2018-06-21 7:30 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49706f0e-03b6-8c43-c35f-c0b0338a17bd@redhat.com \
--to=lijiang@redhat.com \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®