From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f48.google.com (mail-dl1-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2519E378D96 for ; Mon, 23 Feb 2026 22:16:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771885013; cv=none; b=MaM7rydIl+9Y9VvWfg0WbFgnelCW2WHJjyj4Gd8qJHD+a6j8FYOIdPK+1hpvx3PC8u7rQuJZFUMC17tdmX7dZ81GAGMHVDRXotmGFJJU7oJhCCOUU6xP9bveeVY0Hj/miEfWQfvpMoDSYu3f3GvR2uxXZhmbkoUbBcHo/HbKHkA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771885013; c=relaxed/simple; bh=i4RdzhdK9q2F0+y85hN6qPwdyNoPgS2/tdmZuagDBu8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=l3QFKpQ5oW5dyfK2BzqXq8wdhNTsTm95r1VFSmuKi74vRVz88BvQgv60dNXAB9OK5KIYfvexKsIaKfa7KQSTzyBhHBwP6MQwoVsEiSMxxWNCTIQSvlh+c0aPlDJ8qGLQJRZrGm1iKaeeERwemCSkLAf12HmN4Khljh6WyMwT3IQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=W7hdEW4g; arc=none smtp.client-ip=74.125.82.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="W7hdEW4g" Received: by mail-dl1-f48.google.com with SMTP id a92af1059eb24-12721cd256bso5565634c88.1 for ; Mon, 23 Feb 2026 14:16:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771885011; x=1772489811; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Apee3nWLuXPRLBjg9ZZyw8F9mBkuwCMNAMSGJi1YOO8=; b=W7hdEW4geOO1gEJw1iVZvJ/PUNk6YEKugpHfIo9SUovCzs/HIuvoiz5/vb+Sa+CLl9 4peZ2J/kgIBYvprMZQfsLt0sz5dyG0yn3UI1JE1roDzKOQv8ud3nB2MZ+Wj2tVw396mO J8Du1nOdJsCCebb8fwR/qLLT9x5KRolsi5R8OHw/K58FOKOTBsumbBdIW5FhM0qOOcb/ xY/K9abvYO/uDXq4Enmzr0aoIuU4axqbZaeSy9vQ9sHWH8bPc9L0hG+Xa53Mok4Wka98 UeqpG7y+yVh7aFfzaaM0TlZfSnnBAL8S0R9SmD9FgcH1iu6xfvKokF68C1t63Kq/dhHL ZgTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771885011; x=1772489811; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Apee3nWLuXPRLBjg9ZZyw8F9mBkuwCMNAMSGJi1YOO8=; b=ajgGFFpg4DpM/XoAXeDYTBO8kud+MydtUc6mOPaxZKpSm42a9pnK5UJ9wpZL1CIs4K cIwfyJkivU/c5R30vu0uda8cNVFDKTZlVdwKoNqmzEMe/Zl9JkizjlpAzkt+2oD6e0vA gnWB0JodoM60eSZNn4yqjWLmTTtXndWKjATT6Nc+UDVCLd2QxUWi6fvJRSz3DfzvfC27 R0F8NHXFs64E98acVauN6YE2Wqnj45rM8YXmpSF6s0HGZVt2jN7doXuYYf0lQGt1KKeR PcR34ShGv5PZxUDEp/oz9zGTqhF3KS1vlfsuNrWZub2sBQlxF51udjoUL7anIG5OjcQX Whew== X-Forwarded-Encrypted: i=1; AJvYcCVVFUq/P8qMJl4tSOzqn31AHL2ETuWrmt7Enp9QsShfNkzGrtFdP93wHfdwrJ6htUoukQwi3J12PT6uFh0=@vger.kernel.org X-Gm-Message-State: AOJu0YyT1/LPa6xS+YDkK5HMrt+SwlikmYYvbNbZwTSaNUcwmoHmiEbt CmudaFAoh1WvBGuKVhFlk/E9u25M+RAEDRWiFsGFH6Vqm0xkiW0yeOmS X-Gm-Gg: AZuq6aIKEGKc7zcDy0WHOdnkvqZ1UfAx0j8mbGxMKOgtcIew6q56LZ8bLYy8kYEa2Lg Ow0wxcvazncacU4N4rx7JGpnfd8AZeJzrTunBBn+GDYGKXtwv8bEDuupR6OAavroO9FT6ygnJcK 0B2gebOhZWBMoRu/QzOxZ4zoOY0XiE+EMYRF8bcKTgSqb8xEyquaxmNzFxg4kHqzBWcgIT7xlTt +OIk3fm0rXG2ru8/IkoV7vwugxBYwq2x/uBSdRfMr77rdEF6nHjgHqZBGHnXLq03W2v3MHmNjlE AJKdE95KkvcwIfeT5UQNM3ygTK5z4Lzx/QsM3jeiBXNqg0Alx545ijJHXkb7HtTJWCUzSXmoqBF 5R5VOWFtCDVfCez4OTvEBZAprpYdPLUlsMb9OpPbOVOSQGVtv0gZmIAwkBC2b9zwd22l6OEh33h EMVFfsPDWVSC4XJikv1uyO9tOFFUyzxArh0gmLyPTR7vPqKPMtv9TKHQpQe3h54bAnzZJFDtwr9 NCy0Hd4/14YVGkWs41dhjko29V6AEx+aPWBOdo86/D/nZunBQWIqaiGOQcKl47WKNbVM9nnrfCI NAZ54Pg5dqyuvdAgXG/8GFY/1A== X-Received: by 2002:a05:7022:f9e:b0:127:5c57:cffc with SMTP id a92af1059eb24-1276ad18534mr3790197c88.26.1771885010797; Mon, 23 Feb 2026 14:16:50 -0800 (PST) Received: from ?IPV6:2a00:79e0:2e7c:8:b343:b0de:3e59:4e65? ([2a00:79e0:2e7c:8:b343:b0de:3e59:4e65]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1276af7b4c7sm8918703c88.9.2026.02.23.14.16.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Feb 2026 14:16:50 -0800 (PST) Message-ID: <4971aa19-cb79-4bcf-9514-ac288e8e348b@gmail.com> Date: Mon, 23 Feb 2026 14:16:48 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 12/62] drm/gpusvm.c: Fix a locking bug in an error path To: Matthew Brost , Bart Van Assche Cc: Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , linux-kernel@vger.kernel.org, Marco Elver , Christoph Hellwig , Steven Rostedt , Nick Desaulniers , Nathan Chancellor , Kees Cook , Jann Horn , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Himal Prasad Ghimiray , Maarten Lankhorst References: <20260223220102.2158611-1-bart.vanassche@linux.dev> <20260223220102.2158611-13-bart.vanassche@linux.dev> Content-Language: en-US From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/23/26 2:11 PM, Matthew Brost wrote: > On Mon, Feb 23, 2026 at 02:00:12PM -0800, Bart Van Assche wrote: >> From: Bart Van Assche >> >> Only call drm_gpusvm_notifier_unlock() if drm_gpusvm_notifier_lock() was >> called first. This has been detected by the Clang thread-safety >> analyzer. Compile-tested only. >> >> Cc: Thomas Hellström >> Cc: Matthew Brost >> Cc: Himal Prasad Ghimiray >> Cc: Maarten Lankhorst >> Fixes: f1d08a586482 ("drm/gpusvm: Introduce a function to scan the current migration state") >> Signed-off-by: Bart Van Assche >> --- >> drivers/gpu/drm/drm_gpusvm.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/gpu/drm/drm_gpusvm.c b/drivers/gpu/drm/drm_gpusvm.c >> index 24180bfdf5a2..e9b79ab2f83c 100644 >> --- a/drivers/gpu/drm/drm_gpusvm.c >> +++ b/drivers/gpu/drm/drm_gpusvm.c >> @@ -819,7 +819,7 @@ enum drm_gpusvm_scan_result drm_gpusvm_scan_mm(struct drm_gpusvm_range *range, >> >> if (!(pfns[i] & HMM_PFN_VALID)) { >> state = DRM_GPUSVM_SCAN_UNPOPULATED; >> - goto err_free; >> + goto unlock; > > Indeed a problem but we have this fixed in drm-tip. > > git format-patch -1 d287dee565c3c > > 'drm/gpusvm: Fix unbalanced unlock in drm_gpusvm_scan_mm' > > Not sure which tree you are in but this should propagate up to Linus > during the 7.0 cycle. Thanks Matt for the quick follow-up. This patch series is based on Linus' master branch. Since a fix has already been queued in the drm-tip branch, I will drop this patch. Bart.