From: "H. Peter Anvin" <hpa@zytor.com>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
tglx@linutronix.de, mingo@redhat.com, matthew@wil.cx
Subject: Re: [PATCH] x86: Remove never-called arch_setup_msi_irq()
Date: Sun, 18 Jan 2009 22:17:13 -0800 [thread overview]
Message-ID: <49741AE9.3050005@zytor.com> (raw)
In-Reply-To: <2882ab91a8588e9fe2ea45c89d1bc386850a94a3.1232345159.git.michael@ellerman.id.au>
Michael Ellerman wrote:
> Since commit 75c46fa, "x64, x2apic/intr-remap: MSI and MSI-X
> support for interrupt remapping infrastructure", x86 has had an
> implementation of arch_setup_msi_irqs().
>
> That implementation does not call arch_setup_msi_irq(), instead it calls
> setup_irq(). No other x86 code calls arch_setup_msi_irq().
>
> That leaves only arch_setup_msi_irqs() in drivers/pci/msi.c, but that
> routine is overridden by the x86 version of arch_setup_msi_irqs().
>
> So arch_setup_msi_irq() is dead code, remove it.
Applied to tip:x86/cleanups, thanks!
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
prev parent reply other threads:[~2009-01-19 6:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-19 6:06 Michael Ellerman
2009-01-19 6:17 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49741AE9.3050005@zytor.com \
--to=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=matthew@wil.cx \
--cc=michael@ellerman.id.au \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome