mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Amitesh Singh <singh.amitesh@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	olteanv@gmail.com, davem@davemloft.net, edumazet@google.com,
	kuba@kernel.org, pabeni@redhat.com, horms@kernel.org
Subject: Re: [PATCH v2] net: dsa: push hwaccel VLAN tag into payload in dsa_user_xmit()
Date: Wed, 30 Sep 2026 14:41:50 +0200	[thread overview]
Message-ID: <4975c9db-9fa1-479b-976d-a2920d362145@lunn.ch> (raw)
In-Reply-To: <20260930033239.57093-1-singh.amitesh@gmail.com>

> This affects any platform where tx-vlan-offload is enabled or fixed:on
> and cannot be disabled (e.g. imx-dwmac). tag_rtl8_4 and tag_sja1105
> both carried open-coded workarounds for this;

ks8995_xmit() also pushes the tag. This is a new patch:

commit ca30cd47fe7fd1a7eabf6ec120b8d142cfd7eeef
Author: Linus Walleij <linusw@kernel.org>
Date:   Wed Sep 16 12:20:59 2026 +0200

    net: dsa: tag_ks8995: Add the KS8995 tag handling

The fact you missed it suggests you are using an old tree?

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

Please set the Subject correctly.


    Andrew

---
pw-bot: cr

      parent reply	other threads:[~2026-09-30 12:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-30  3:32 Amitesh Singh
2026-09-30  3:39 ` netdev-bot+sinfo
2026-09-30 12:41 ` Andrew Lunn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4975c9db-9fa1-479b-976d-a2920d362145@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=singh.amitesh@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®