From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756480AbcIGH6A (ORCPT ); Wed, 7 Sep 2016 03:58:00 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:60496 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751174AbcIGH55 (ORCPT ); Wed, 7 Sep 2016 03:57:57 -0400 From: Arnd Bergmann To: Sebastian Reichel Cc: Phil Reid , YH Huang , Joshua Clayton , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] power: supply: sbs-battery: simplify DT parsing Date: Wed, 07 Sep 2016 09:58:10 +0200 Message-ID: <4977026.Nm6AJ7K8UK@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <20160906235523.ff4opq56gg4ln6xv@earth> References: <20160906131643.1930011-1-arnd@arndb.de> <20160906235523.ff4opq56gg4ln6xv@earth> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:Kbt7shYPwLnavppZ3sJ598OqKDx3a79j9nlJq2RsvEwOn85nDhB 8cNBCc1gyR2dkjTXy1VWvgChNQz5EqZ2YRCXCJ5XvVw2DHuWYXz+am17G64oTtjbKZcP9kM xa8BUJPxRN6LtPOd0CpJHalWwwAFw0CHiQ8s2SV1b60klT3Ol5pmoehogmOX9510VKmeNDx Exfp1zBvYwEvDq8xG3o9A== X-UI-Out-Filterresults: notjunk:1;V01:K0:o0beNbyOAmA=:WSHDMdicqY/jG4Ui58C+0N 5Uou5c6bzbqdXPkKhIObGHnlGwqFOgAoGlhUrdh+/xS0OzQfHQO8Y82yMHDDKRRtCTnV8nlUO lS6ZoNYIar+Ubq6QIQC/foGZDrzNKv24kZmsYFgrTUVru9JYF/1qlpxiIGFmtdqoIQ+F/B/iz IGjewAqq9rmXGFP5/1G1lW/Xw7dEyya0jV43Smu+WGHFMbPqUpDu5V821Jqj4PaLCnvkw4DpK Utk5cSrHngd5/Mz5wCOOYu8tABB8EbMN+f4yh81Uynt1WGoVCohc43A+jJkWghG9Zdp2ljzZd laFyK/K3Gkmr9vjsYoTWx6oC2o8d9LPacT5KVi1Kds0JJvYL178BD56zW5q5MmaYZ50HQgsh2 mZMsEF/Cb2/7jf0CpQMPm/Mv7VmFq/fOS65ulLL2BcJCBQEh3ek5uy0PrpRAiQXVLjTRlkeiH aQZGnUoaDyf1KVpNetmMGHWAB2LkqvEsP0QDdOxOwgEuMSJtbrzeBSekzTE2Gbc3SaHHwXYW3 Qx0bVJoJft2BLdiakm54I1wECLJIJNClmcOHlaMjm6MNV1JzsT4SLx27+6Rf/K/ab9u3YFK27 2chFA6gzkr2y8BHeeBtS/H/+fTyr0/D/R7KpFrWcPjhWjUMpfsKAPuKwBKs95NuMeED5dfvmr kJepRD+4JrY79xsFXay8V5T1GD1x8mrv5966aUp0cBH3hNq00BJp7v+eCsifXX1rbtsnPolbu liwmvs1Pah4IWDbS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, September 7, 2016 1:55:23 AM CEST Sebastian Reichel wrote: > > Patch looks fine to me. Actually I already asked Phil to > implement your change [0]. I just queued it to power-supply's > for-next branch. > > [0] https://marc.info/?l=linux-pm&m=147273382018953&w=2 Glad to see we had the same thought. ;-) I see that we went for different defaults for chip->poll_retry_count: I concluded that '0' would be the correct default, while you suggested '1' in your reply. Can you double-check the code and see which one is right? Arnd