mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Daniel Hokka Zakrisson" <daniel@hozac.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: linux-kernel@vger.kernel.org,
	containers@lists.linux-foundation.org, oleg@tv-sign.ru,
	xemul@openvz.org, akpm@linux-foundation.org
Subject: Re: [PATCH 2/2] signals: replace p->pid == 1 check with a check  for task_child_reaper
Date: Thu, 17 Jul 2008 20:21:37 +0200 (CEST)	[thread overview]
Message-ID: <49797.192.168.102.6.1216318897.squirrel@intranet> (raw)
In-Reply-To: <m14p6ov1j0.fsf@frodo.ebiederm.org>

Eric W. Biederman wrote:
> Daniel Hokka Zakrisson <daniel@hozac.com> writes:
>
>> p->pid == 1 is insufficient when there are multiple pid namespaces.
>> Instead, check whether the task is in the current task's
>> child reaper's thread group.
>
> We should just drop the check for init as it is redundant.

I'm not sure what you mean? Without protecting init here, kill -s 9 -- -1
will kill it (i.e. the init in the pid namespace). E.g.:
# vspace --new --pid --mount -- bash
# bash -c 'kill -s 9 -- -1'
will kill off all those processes, and dispose of the pid namespace.

> Eric

-- 
Daniel Hokka Zakrisson

  reply	other threads:[~2008-07-17 18:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-17 14:56 Daniel Hokka Zakrisson
2008-07-17 17:55 ` Eric W. Biederman
2008-07-17 18:21   ` Daniel Hokka Zakrisson [this message]
2008-07-17 18:51     ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49797.192.168.102.6.1216318897.squirrel@intranet \
    --to=daniel@hozac.com \
    --cc=akpm@linux-foundation.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®